Okay...this pretty much cleans out the include files.

I'm able to get through a 'make' of the backend with no errors except
the occasional 'might not be initialized error', which is nothing major,
just annoying.

Have a few patches from D'Arcy to incorporate, but am waiting until I can
get a clean compile first, which I'm hoping to have before bed, or sometime
tomorrow.

17 files changed, 1 insertions, 48 deletions

diff --git a/src/include/bootstrap/bootstrap.h b/src/include/bootstrap/bootstrap.h
index 066f6c8b9c..a66caf927a 100644
--- a/src/include/bootstrap/bootstrap.h
+++ b/src/include/bootstrap/bootstrap.h
@@ -13,22 +13,7 @@
 #ifndef BOOTSTRAP_H
 #define BOOTSTRAP_H
 
-#include <sys/file.h>
-#include <stdio.h>
-#include <string.h>
-#include <signal.h>
-#include <ctype.h>
 
-#include "access/htup.h"
-#include "access/itup.h"
-#include "access/relscan.h"
-#include "access/skey.h"
-#include "utils/tqual.h"
-#include "storage/buf.h"
-#include "storage/bufmgr.h"	/* for BufferManagerFlush */
-#include "utils/portal.h"
-#include "utils/elog.h"
-#include "utils/rel.h"
 
 #define	MAXATTR 40		/* max. number of attributes in a relation */
 
diff --git a/src/include/catalog/pg_amop.h b/src/include/catalog/pg_amop.h
index ae42991056..e01ca756ba 100644
--- a/src/include/catalog/pg_amop.h
+++ b/src/include/catalog/pg_amop.h
@@ -24,7 +24,6 @@
  *	can be read by both genbki.sh and the C compiler.
  * ----------------
  */
-#include "access/istrat.h"
 
 /* ----------------
  *	pg_amop definition.  cpp turns this into
diff --git a/src/include/catalog/pg_version.h b/src/include/catalog/pg_version.h
index db25fa6de1..be1d80cc3a 100644
--- a/src/include/catalog/pg_version.h
+++ b/src/include/catalog/pg_version.h
@@ -24,7 +24,6 @@
  *	can be read by both genbki.sh and the C compiler.
  * ----------------
  */
-#include "utils/nabstime.h"
 
 /* ----------------
  *	pg_version definition.  cpp turns this into
diff --git a/src/include/commands/async.h b/src/include/commands/async.h
index fc6ba68d68..cd603f26f7 100644
--- a/src/include/commands/async.h
+++ b/src/include/commands/async.h
@@ -13,7 +13,6 @@
 #ifndef	ASYNC_H
 #define	ASYNC_H
 
-#include "nodes/memnodes.h"
 
 extern void Async_NotifyHandler(SIGNAL_ARGS);
 extern void Async_Notify(char *relname);
diff --git a/src/include/commands/version.h b/src/include/commands/version.h
index 7c91835411..2128a557e5 100644
--- a/src/include/commands/version.h
+++ b/src/include/commands/version.h
@@ -13,7 +13,6 @@
 #ifndef VERSION_H
 #define VERSION_H
 
-#include "nodes/pg_list.h"
 
 extern void DefineVersion(char *name, char *fromRelname, char *date);
 extern void VersionCreate(char *vname, char *bname);
diff --git a/src/include/lib/qsort.h b/src/include/lib/qsort.h
index 6fc4d3da8d..d704746597 100644
--- a/src/include/lib/qsort.h
+++ b/src/include/lib/qsort.h
@@ -13,7 +13,6 @@
 #ifndef	QSORT_H
 #define	QSORT_H
 
-#include <sys/types.h>
 
 extern void pg_qsort(void *bot,
 		     size_t nmemb,
diff --git a/src/include/libpq/auth.h b/src/include/libpq/auth.h
index 7afb85eca5..82610880a0 100644
--- a/src/include/libpq/auth.h
+++ b/src/include/libpq/auth.h
@@ -13,7 +13,7 @@
 #ifndef AUTH_H
 #define	AUTH_H
 
-#include "libpq/pqcomm.h"
+#include <libpq/pqcomm.h>
 
 /*----------------------------------------------------------------
  * Common routines and definitions
diff --git a/src/include/libpq/hba.h b/src/include/libpq/hba.h
index 96da35d768..a3533148eb 100644
--- a/src/include/libpq/hba.h
+++ b/src/include/libpq/hba.h
@@ -11,7 +11,6 @@
 #ifndef HBA_H
 #define	HBA_H
 
-#include <libpq/pqcomm.h>
 
 extern int
 hba_recvauth(const Port *port, const char database[], const char user[],
diff --git a/src/include/libpq/libpq-fs.h b/src/include/libpq/libpq-fs.h
index 47cfbf412d..31c2b255bb 100644
--- a/src/include/libpq/libpq-fs.h
+++ b/src/include/libpq/libpq-fs.h
@@ -13,16 +13,10 @@
 #ifndef LIBPQ_FS_H
 #define LIBPQ_FS_H
 
-#include "lib/dllist.h"
-#include <sys/file.h>
-#include <sys/stat.h>
 
-#include <fcntl.h>		/* for O_ on some */
 #ifndef WIN32
-#include <unistd.h>		/* for SEEK_ on most */
 #endif /* WIN32 */
 #ifndef SEEK_SET
-#include <stdio.h>		/* for SEEK_ on others */
 #endif /* SEEK_SET */
 
 /* UNIX compatibility junk.  This should be in all systems' include files,
diff --git a/src/include/libpq/pqsignal.h b/src/include/libpq/pqsignal.h
index 79fdda0e98..311275031b 100644
--- a/src/include/libpq/pqsignal.h
+++ b/src/include/libpq/pqsignal.h
@@ -17,7 +17,6 @@
 #ifndef PQSIGNAL_H
 #define PQSIGNAL_H
 
-#include <signal.h>
 
 
 typedef void (*pqsigfunc)(int);
diff --git a/src/include/miscadmin.h b/src/include/miscadmin.h
index bbdad4f22c..ec1e6749d4 100644
--- a/src/include/miscadmin.h
+++ b/src/include/miscadmin.h
@@ -27,10 +27,6 @@
  *    globals.h --                                                           *
  *****************************************************************************/
 
-#include "postgres.h"
-
-/* #include "storage/sinval.h" */
-
 /*
  * from postmaster/postmaster.c
  */
diff --git a/src/include/optimizer/internal.h b/src/include/optimizer/internal.h
index d01301b08d..9b7dc67bfc 100644
--- a/src/include/optimizer/internal.h
+++ b/src/include/optimizer/internal.h
@@ -22,13 +22,6 @@
  *    
  */
 
-#include "nodes/nodes.h"
-#include "nodes/primnodes.h"
-#include "nodes/plannodes.h"
-#include "parser/parsetree.h"
-#include "nodes/relation.h"
-#include "catalog/pg_index.h"	/* for INDEX_MAX_KEYS */
-#include "utils/syscache.h"	/* for SearchSysCacheGetAttribute, etc. */
 
 /*
  *    	System-dependent tuning constants
diff --git a/src/include/optimizer/planner.h b/src/include/optimizer/planner.h
index 78e3278d72..47fa1b82c9 100644
--- a/src/include/optimizer/planner.h
+++ b/src/include/optimizer/planner.h
@@ -14,8 +14,6 @@
 #define PLANNER_H
 
 /*
-#include "optimizer/internal.h"
-#include "parser/parse_query.h"
 */
 
 extern Plan *planner(Query *parse);
diff --git a/src/include/parser/parsetree.h b/src/include/parser/parsetree.h
index 772059d1fb..21fb9bf665 100644
--- a/src/include/parser/parsetree.h
+++ b/src/include/parser/parsetree.h
@@ -18,8 +18,6 @@
  *	need pg_list.h for definitions of CAR(), etc. macros
  * ----------------
  */
-#include "nodes/pg_list.h"
-#include "nodes/parsenodes.h"
 
 /* ----------------
  *	range table macros
diff --git a/src/include/regex/regexp.h b/src/include/regex/regexp.h
index bf39dab693..25438e3f37 100644
--- a/src/include/regex/regexp.h
+++ b/src/include/regex/regexp.h
@@ -57,9 +57,7 @@ typedef struct regexp {
 	char program[1];	/* Unwarranted chumminess with compiler. */
 } regexp;
 
-/* #include <sys/cdefs.h> */
 /* since not all systems have cdefs.h, we'll use our own here - jolly */
-#include "cdefs.h"
 
 __BEGIN_DECLS
 regexp *pg95_regcomp __P((const char *));
diff --git a/src/include/rewrite/locks.h b/src/include/rewrite/locks.h
index 7246bbe81c..59fe7d2c0c 100644
--- a/src/include/rewrite/locks.h
+++ b/src/include/rewrite/locks.h
@@ -13,7 +13,6 @@
 #ifndef	LOCKS_H
 #define	LOCKS_H
 
-#include "rewrite/prs2lock.h"
 
 extern List *matchLocks(CmdType event, RuleLock *rulelocks, int varno,
 			Query *parsetree);
diff --git a/src/include/rewrite/rewriteSupport.h b/src/include/rewrite/rewriteSupport.h
index bafc04b1e7..708d002422 100644
--- a/src/include/rewrite/rewriteSupport.h
+++ b/src/include/rewrite/rewriteSupport.h
@@ -13,7 +13,6 @@
 #ifndef	REWRITESUPPORT_H
 #define	REWRITESUPPORT_H
 
-#include "nodes/pg_list.h"
 
 extern int IsDefinedRewriteRule(char *ruleName);