diff options
| author | Magnus Hagander | 2007-06-04 11:59:40 +0000 |
|---|---|---|
| committer | Magnus Hagander | 2007-06-04 11:59:40 +0000 |
| commit | 5002dfe049cc0c9a0c4a4dcf85f74517b65a8a8a (patch) | |
| tree | 49b96a831ef9323c228f8fcc901c142374722577 | |
| parent | e895525ef28c69de44bf25e1bb262c68f2ee5356 (diff) | |
On win32, don't use SO_REUSEADDR for TCP sockets.
Per failure on buildfarm member baiji and subsequent discussion.
| -rw-r--r-- | src/backend/libpq/pqcomm.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c index 3bb2d7c5ae..477a7a5387 100644 --- a/src/backend/libpq/pqcomm.c +++ b/src/backend/libpq/pqcomm.c @@ -337,6 +337,16 @@ StreamServerPort(int family, char *hostName, unsigned short portNumber, continue; } +#ifndef WIN32 + /* + * Without the SO_REUSEADDR flag, a new postmaster can't be started right away after + * a stop or crash, giving "address already in use" error on TCP ports. + * + * On win32, however, this behavior only happens if the SO_EXLUSIVEADDRUSE is set. + * With SO_REUSEADDR, win32 allows multiple servers to listen on the same address, + * resulting in unpredictable behavior. With no flags at all, win32 behaves as + * Unix with SO_REUSEADDR. + */ if (!IS_AF_UNIX(addr->ai_family)) { if ((setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, @@ -349,6 +359,7 @@ StreamServerPort(int family, char *hostName, unsigned short portNumber, continue; } } +#endif #ifdef IPV6_V6ONLY if (addr->ai_family == AF_INET6) |