diff options
| author | Tom Lane | 2009-06-27 21:06:46 +0000 |
|---|---|---|
| committer | Tom Lane | 2009-06-27 21:06:46 +0000 |
| commit | 4f80dcf09bc02ed2475d0db5af6cf3b0d1b3dfe2 (patch) | |
| tree | af471f6bc6b20634e768c129bc68979249854b4e | |
| parent | f049782dd7b81fcb8634a8d652dc9c48333f0c3a (diff) | |
Revert addition of "o" to tar options. This was intended to fix bug #4883,
but the cure appears to be worse than the disease. It turns out that GNU
tar versions 1.14.x misinterpret -o as --same-owner, not --no-same-owner,
leading to exactly the wrong behavior for both root and nonroot users.
While that bug has been fixed for nearly five years, these tar versions
are still found in the wild, notably in OS X 10.4. Given that #4883 was
the first complaint we'd heard, it's definitely not worth fixing at the
risk of breaking things for other users. Perhaps revisit at a later date
when we're not up against a release deadline.
| -rw-r--r-- | doc/Makefile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/Makefile b/doc/Makefile index db7c66a251..004218afaf 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -53,7 +53,7 @@ man1/.timestamp: man7/.timestamp @echo timestamp >$@ man7/.timestamp: man.tar.gz - gzip -d -c $< | $(TAR) xof - + gzip -d -c $< | $(TAR) xf - ifneq ($(sqlmansectnum),7) for file in man1/*.1; do \ mv $$file $$file.bak && \ @@ -76,7 +76,7 @@ endif # found_man install: all installdirs ifdef found_html - gzip -d -c $(srcdir)/postgres.tar.gz | ( cd $(DESTDIR)$(htmldir)/html && $(TAR) xof - ) + gzip -d -c $(srcdir)/postgres.tar.gz | ( cd $(DESTDIR)$(htmldir)/html && $(TAR) xf - ) endif ifdef found_man for file in man1/*.1 man$(sqlmansectnum)/*.$(sqlmansect) ; do \ |