summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2004-10-24 00:54:12 +0000
committerTom Lane2004-10-24 00:54:12 +0000
commit363eda7b15e7bf357b60a24cc9acd1893eb02227 (patch)
tree49cbc30349a3d1fe7ed193cbecaa4c6f62b3350d
parent6ef71500858f50abff366af2e42f485eab54a613 (diff)
If we're going to test for switch validity by observing whether the
compiler emits any warnings, the test program had better be 100% correct, not only 90% correct. The recent addition of -Wold-style-definition broke thread-safety detection on every platform that has that switch, because the test program used an old-style definition.
-rw-r--r--config/acx_pthread.m44
-rwxr-xr-xconfigure4
2 files changed, 6 insertions, 2 deletions
diff --git a/config/acx_pthread.m4 b/config/acx_pthread.m4
index 5f9071056e..254a383a9b 100644
--- a/config/acx_pthread.m4
+++ b/config/acx_pthread.m4
@@ -134,8 +134,10 @@ for flag in $acx_pthread_flags; do
# We find them by checking stderror.
cat >conftest.$ac_ext <<_ACEOF
int
-main ()
+main (int argc, char **argv)
{
+ (void) argc;
+ (void) argv;
return 0;
}
_ACEOF
diff --git a/configure b/configure
index 5eaa809ae8..a96ff78d0e 100755
--- a/configure
+++ b/configure
@@ -13606,8 +13606,10 @@ rm -f conftest.$ac_objext conftest$ac_exeext conftest.$ac_ext
# We find them by checking stderror.
cat >conftest.$ac_ext <<_ACEOF
int
-main ()
+main (int argc, char **argv)
{
+ (void) argc;
+ (void) argv;
return 0;
}
_ACEOF