summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2008-01-15 22:18:20 +0000
committerTom Lane2008-01-15 22:18:20 +0000
commit1a9d6f189ea9c065edc6256387ecee512c60dc60 (patch)
treed9ef54b34dfc8fa6d27ace2837f3ba3e40f395df
parentde56b9ec34e9efe8b44ec7fc5e88a413187d2b24 (diff)
Be less wishy-washy in the documentation and comments about whether a
ParameterStatus message can be sent during COPY OUT: it's definitely possible, since COPY from a SELECT subquery can trigger any user-defined function.
-rw-r--r--doc/src/sgml/protocol.sgml8
-rw-r--r--src/interfaces/libpq/fe-protocol3.c5
2 files changed, 6 insertions, 7 deletions
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 13ab98a4fe..c26cccc45f 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -1044,10 +1044,10 @@
</para>
<para>
- It is possible for NoticeResponse messages to be interspersed between
- CopyData messages; frontends must handle this case, and should be
- prepared for other asynchronous message types as well (see <xref
- linkend="protocol-async">). Otherwise, any message type other than
+ It is possible for NoticeResponse and ParameterStatus messages to be
+ interspersed between CopyData messages; frontends must handle these cases,
+ and should be prepared for other asynchronous message types as well (see
+ <xref linkend="protocol-async">). Otherwise, any message type other than
CopyData or CopyDone may be treated as terminating copy-out mode.
</para>
diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c
index 5e352480cd..f473588526 100644
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interfaces/libpq/fe-protocol3.c
@@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn)
/*
* If it's a legitimate async message type, process it. (NOTIFY
* messages are not currently possible here, but we handle them for
- * completeness. NOTICE is definitely possible, and ParameterStatus
- * could probably be made to happen.) Otherwise, if it's anything
- * except Copy Data, report end-of-copy.
+ * completeness.) Otherwise, if it's anything except Copy Data,
+ * report end-of-copy.
*/
switch (id)
{