summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmit Kapila2023-11-07 06:02:33 +0000
committerAmit Kapila2023-11-07 06:02:33 +0000
commit8af917be6badf0b50759fd7d9ca4e3e7977dd486 (patch)
treee0e097d30b0f987fa4993f296391c723e4989b87
parentc2bdd2c5b1d48a7e39e1a8d5e1d90b731b53c4c9 (diff)
Fix the test 003_logical_slots.
pg_upgrade test 003_logical_slots was leaving files like delete_old_cluster.sh in the source directory for VPATH and meson builds. The fix is to change the directory to tmp_check before running the test as is done in the similar test in 002_pg_upgrade. Reported-by: Peter Eisentraut, Andrew Dunstan Author: Hayato Kuroda based on a suggestion by Andrew Dunstan Reviewed-by: Peter Smith, Hou Zhijie Discussion: http://postgr.es/m/[email protected] Discussion: http://postgr.es/m/TYAPR01MB5866D7B89DC5688256D980C2F5A9A@TYAPR01MB5866.jpnprd01.prod.outlook.com
-rw-r--r--src/bin/pg_upgrade/t/003_logical_slots.pl5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/bin/pg_upgrade/t/003_logical_slots.pl b/src/bin/pg_upgrade/t/003_logical_slots.pl
index af9f350431..5b01cf8c40 100644
--- a/src/bin/pg_upgrade/t/003_logical_slots.pl
+++ b/src/bin/pg_upgrade/t/003_logical_slots.pl
@@ -34,6 +34,11 @@ my @pg_upgrade_cmd = (
'-P', $newpub->port,
$mode);
+# In a VPATH build, we'll be started in the source directory, but we want
+# to run pg_upgrade in the build directory so that any files generated finish
+# in it, like delete_old_cluster.{sh,bat}.
+chdir ${PostgreSQL::Test::Utils::tmp_check};
+
# ------------------------------
# TEST: Confirm pg_upgrade fails when the new cluster has wrong GUC values