diff options
| author | Heikki Linnakangas | 2011-10-08 08:17:40 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2011-10-08 08:17:40 +0000 |
| commit | 1ef60dab7049ffac52dee60b5788b6c7bc1f9d67 (patch) | |
| tree | b4fe01576a9152096dc9b9e5192b1521f4f110cb | |
| parent | 041dceb2590081c397daeda84ff28ffc71a51fb0 (diff) | |
Don't let transform_null_equals=on affect CASE foo WHEN NULL ... constructs.
transform_null_equals is only supposed to affect "foo = NULL" expressions
given directly by the user, not the internal "foo = NULL" expression
generated from CASE-WHEN.
This fixes bug #6242, reported by Sergey. Backpatch to all supported
branches.
| -rw-r--r-- | src/backend/parser/parse_expr.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c index 65d03adc49..79328c9979 100644 --- a/src/backend/parser/parse_expr.c +++ b/src/backend/parser/parse_expr.c @@ -836,12 +836,15 @@ transformAExprOp(ParseState *pstate, A_Expr *a) /* * Special-case "foo = NULL" and "NULL = foo" for compatibility with * standards-broken products (like Microsoft's). Turn these into IS NULL - * exprs. + * exprs. (If either side is a CaseTestExpr, then the expression was + * generated internally from a CASE-WHEN expression, and + * transform_null_equals does not apply.) */ if (Transform_null_equals && list_length(a->name) == 1 && strcmp(strVal(linitial(a->name)), "=") == 0 && - (exprIsNullConstant(lexpr) || exprIsNullConstant(rexpr))) + (exprIsNullConstant(lexpr) || exprIsNullConstant(rexpr)) && + (!IsA(lexpr, CaseTestExpr) && !IsA(rexpr, CaseTestExpr))) { NullTest *n = makeNode(NullTest); |