summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Haas2011-08-19 15:57:38 +0000
committerRobert Haas2011-08-19 16:00:45 +0000
commit10c378f2350a8321ea76fc02d821a9e7707c7563 (patch)
treefb31b324bcffcb39a49f39073e1b055921c975a9
parenta64bdf5f657f4dd58f1b2df7b69f890d84952597 (diff)
Fix contrib/sepgsql and contrib/xml2 to always link required libraries.
contrib/xml2 can get by without libxslt; the relevant features just won't work. But if doesn't have libxml2, or if sepgsql doesn't have libselinux, the link succeeds but the module then fails to work at load time. To avoid that, link the require libraries unconditionally, so that it will be clear at link-time that there is a problem. Per discussion with Tom Lane and KaiGai Kohei.
-rw-r--r--contrib/sepgsql/Makefile2
-rw-r--r--contrib/xml2/Makefile2
2 files changed, 2 insertions, 2 deletions
diff --git a/contrib/sepgsql/Makefile b/contrib/sepgsql/Makefile
index 7f997eee99..1978ccf8c8 100644
--- a/contrib/sepgsql/Makefile
+++ b/contrib/sepgsql/Makefile
@@ -19,7 +19,7 @@ include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
-SHLIB_LINK += $(filter -lselinux, $(LIBS))
+SHLIB_LINK += -lselinux
REGRESS_OPTS += --launcher $(top_builddir)/contrib/sepgsql/launcher
check_selinux_environment:
diff --git a/contrib/xml2/Makefile b/contrib/xml2/Makefile
index ad325723c9..be3d018cf5 100644
--- a/contrib/xml2/Makefile
+++ b/contrib/xml2/Makefile
@@ -8,7 +8,7 @@ DATA = xml2--1.0.sql xml2--unpackaged--1.0.sql
REGRESS = xml2
-SHLIB_LINK += $(filter -lxslt, $(LIBS)) $(filter -lxml2, $(LIBS))
+SHLIB_LINK += $(filter -lxslt, $(LIBS)) -lxml2
ifdef USE_PGXS
PG_CONFIG = pg_config