diff options
| author | Michael Paquier | 2023-01-19 04:13:05 +0000 |
|---|---|---|
| committer | Michael Paquier | 2023-01-19 04:13:05 +0000 |
| commit | 7e8a80d1fefd1e96992652ed5a628c437971c82e (patch) | |
| tree | 15e867da56b7571f54cb0856dc6e2f6f2d2dbc49 | |
| parent | 6ba6306256a37524bbbc76402e69ef3d32d355fd (diff) | |
Add missing assign hook for GUC checkpoint_completion_target
This is wrong since 88e9823, that has switched the WAL sizing
configuration from checkpoint_segments to min_wal_size and
max_wal_size. This missed the recalculation of the internal value of
the internal "CheckPointSegments", that works as a mapping of the old
GUC checkpoint_segments, on reload, for example, and it controls the
timing of checkpoints depending on the volume of WAL generated.
Most users tend to leave checkpoint_completion_target at 0.9 to smooth
the I/O workload, which is why I guess this has gone unnoticed for so
long, still it can be useful to tweak and reload the value dynamically
in some cases to control the timing of checkpoints.
Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com
Backpatch-through: 11
| -rw-r--r-- | src/backend/utils/misc/guc_tables.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 5025e80f89..cd0fc2cb8f 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -3713,7 +3713,7 @@ struct config_real ConfigureNamesReal[] = }, &CheckPointCompletionTarget, 0.9, 0.0, 1.0, - NULL, NULL, NULL + NULL, assign_checkpoint_completion_target, NULL }, { |