summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2023-01-23 18:50:49 +0000
committerTom Lane2023-01-23 18:50:49 +0000
commit62e1e28bf76910ffe47ddbc5c1fade41e1a65dac (patch)
treed620c2529cdacbdb5a618259acd168fa5423a982
parent3cece34be842178a3c5697a58e03fb4a5d576378 (diff)
Fix pgindent --show-diff option.
At least on my machine, the initial coding of this didn't actually work, because interpolation of "$post_fh->filename" doesn't act as intended. I threw in some double quotes too, just in case anybody tries to run this in a path containing spaces.
-rwxr-xr-xsrc/tools/pgindent/pgindent3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent
index 73caa831d0..5eff1f8032 100755
--- a/src/tools/pgindent/pgindent
+++ b/src/tools/pgindent/pgindent
@@ -299,12 +299,13 @@ sub show_diff
my $source_filename = shift;
my $post_fh = new File::Temp(TEMPLATE => "pgdiffXXXXX");
+ my $post_fh_filename = $post_fh->filename;
print $post_fh $indented;
$post_fh->close();
- my $diff = `diff -upd $source_filename $post_fh->filename 2>&1`;
+ my $diff = `diff -upd "$source_filename" "$post_fh_filename" 2>&1`;
return $diff;
}