diff options
| author | Nathan Bossart | 2024-10-07 21:49:20 +0000 |
|---|---|---|
| committer | Nathan Bossart | 2024-10-07 21:49:20 +0000 |
| commit | 8318f2b170d81e6792b90f2aa2b491a2b7add441 (patch) | |
| tree | e529f3e702e764e350f1cbabc1a021630a66f7b7 | |
| parent | 5d6187d2a28326b3414c394ec4c28c51bb513c44 (diff) | |
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
| -rw-r--r-- | src/bin/scripts/vacuumdb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c index 249622068a..d07ab7d67e 100644 --- a/src/bin/scripts/vacuumdb.c +++ b/src/bin/scripts/vacuumdb.c @@ -684,7 +684,8 @@ vacuum_one_database(ConnParams *cparams, * Exclude temporary tables, beginning the WHERE clause. */ appendPQExpBufferStr(&catalog_query, - " WHERE c.relpersistence != " CppAsString2(RELPERSISTENCE_TEMP)); + " WHERE c.relpersistence OPERATOR(pg_catalog.!=) " + CppAsString2(RELPERSISTENCE_TEMP) "\n"); /* * Used to match the tables or schemas listed by the user, for the WHERE |