summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2011-05-11 18:43:01 +0000
committerTom Lane2011-05-11 18:43:01 +0000
commit6fc6686b48bc569b05ce711d18cf964498b217f2 (patch)
tree94ccefaa848c647287de1e38c7188a07da6d1593
parenta0c8514149de92d48a8cf0f1a1458486851980a4 (diff)
Clean up parsing of CREATE TRIGGER's argument list.
Use ColLabel in place of ColId, so that reserved words are accepted as if they were not reserved. Also, remove BCONST and XCONST, which were never documented as allowed. Allowing those exposes to users an implementation detail, namely the format in which the lexer outputs such constants, that seems unwise to expose. No documentation change needed, since this just makes the code act more like you'd expect from reading the CREATE TRIGGER man page. Per complaint from Szymon Guz and subsequent discussion.
-rw-r--r--src/backend/parser/gram.y4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index dd95961841..1d39674de4 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -4126,9 +4126,7 @@ TriggerFuncArg:
}
| FCONST { $$ = makeString($1); }
| Sconst { $$ = makeString($1); }
- | BCONST { $$ = makeString($1); }
- | XCONST { $$ = makeString($1); }
- | ColId { $$ = makeString($1); }
+ | ColLabel { $$ = makeString($1); }
;
OptConstrFromTable: