summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeikki Linnakangas2024-03-15 11:06:57 +0000
committerHeikki Linnakangas2024-03-15 11:06:57 +0000
commite2e3b8ae9ed73fcd3096c5ca93971891a7767388 (patch)
treef8d677691bb58534354f9dc5379f6b67e27cbb39
parent071e3ad59d6fd2d6d1277b2bd9579397d10ded28 (diff)
Disable tests using injection points in installcheck
The 'gin' test injections faults to GIN index build. If another test running concurrently in the same cluster also tries to create a GIN index, it will hit the fault, too. To fix, disable tests using injection points when running against an existing cluster. A better long-term solution would be to make the injection points scoped to the database or process, but this will do for now. Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%[email protected] Discussion: https://www.postgresql.org/message-id/[email protected]
-rw-r--r--src/test/modules/gin/Makefile3
-rw-r--r--src/test/modules/gin/meson.build2
-rw-r--r--src/test/modules/injection_points/Makefile3
-rw-r--r--src/test/modules/injection_points/meson.build2
4 files changed, 10 insertions, 0 deletions
diff --git a/src/test/modules/gin/Makefile b/src/test/modules/gin/Makefile
index a7731b7fa18..81ca6bfe35a 100644
--- a/src/test/modules/gin/Makefile
+++ b/src/test/modules/gin/Makefile
@@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points
REGRESS = gin_incomplete_splits
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/gin/meson.build b/src/test/modules/gin/meson.build
index 9734b51de2d..5ec0760a276 100644
--- a/src/test/modules/gin/meson.build
+++ b/src/test/modules/gin/meson.build
@@ -12,5 +12,7 @@ tests += {
'sql': [
'gin_incomplete_splits',
],
+ # The injection points are cluster-wide, so disable installcheck
+ 'runningcheck': false,
},
}
diff --git a/src/test/modules/injection_points/Makefile b/src/test/modules/injection_points/Makefile
index 2cbbae4e0a0..4248671513a 100644
--- a/src/test/modules/injection_points/Makefile
+++ b/src/test/modules/injection_points/Makefile
@@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"
REGRESS = injection_points
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/injection_points/meson.build b/src/test/modules/injection_points/meson.build
index ee37573f2ab..a29217f75f9 100644
--- a/src/test/modules/injection_points/meson.build
+++ b/src/test/modules/injection_points/meson.build
@@ -33,5 +33,7 @@ tests += {
'sql': [
'injection_points',
],
+ # The injection points are cluster-wide, so disable installcheck
+ 'runningcheck': false,
},
}