summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2023-04-20 22:12:32 +0000
committerTom Lane2023-04-20 22:12:32 +0000
commitc976ccc9e5578a6999f1848d34b869add1525cb5 (patch)
tree5069be2f68f089348d59b64aac056176d013aec4
parent7228f2f812f58627465fc00dbfbec5f6d15d8b5b (diff)
Use --strip-unneeded when stripping static libraries with GNU strip.
We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces smaller output (as "-x" alone does not remove debug symbols). Moreover it seems that llvm-strip, although it identifies as GNU strip, misbehaves when given "-x" for this purpose. It's unclear whether that's intentional or a bug in llvm-strip, but in any case it seems like changing to use --strip-unneeded in all cases should be a win. Note that this doesn't change our behavior when dealing with non-GNU strip. Per gripes from Ed Maste and Palle Girgensohn. Back-patch, in case anyone wants to use llvm-strip with stable branches. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected]
-rw-r--r--config/programs.m42
-rwxr-xr-xconfigure2
2 files changed, 2 insertions, 2 deletions
diff --git a/config/programs.m4 b/config/programs.m4
index aa84bfdb9e4..99fa9a13487 100644
--- a/config/programs.m4
+++ b/config/programs.m4
@@ -270,7 +270,7 @@ AC_DEFUN([PGAC_CHECK_STRIP],
AC_MSG_CHECKING([whether it is possible to strip libraries])
if test x"$STRIP" != x"" && "$STRIP" -V 2>&1 | grep "GNU strip" >/dev/null; then
- STRIP_STATIC_LIB="$STRIP -x"
+ STRIP_STATIC_LIB="$STRIP --strip-unneeded"
STRIP_SHARED_LIB="$STRIP --strip-unneeded"
AC_MSG_RESULT(yes)
else
diff --git a/configure b/configure
index 99b639b2add..7325b68aefb 100755
--- a/configure
+++ b/configure
@@ -9051,7 +9051,7 @@ fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether it is possible to strip libraries" >&5
$as_echo_n "checking whether it is possible to strip libraries... " >&6; }
if test x"$STRIP" != x"" && "$STRIP" -V 2>&1 | grep "GNU strip" >/dev/null; then
- STRIP_STATIC_LIB="$STRIP -x"
+ STRIP_STATIC_LIB="$STRIP --strip-unneeded"
STRIP_SHARED_LIB="$STRIP --strip-unneeded"
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
$as_echo "yes" >&6; }