summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Gustafsson2025-04-17 10:58:00 +0000
committerDaniel Gustafsson2025-04-17 10:58:00 +0000
commitb669293e3432ee8fdcd44854a945837bb18eea5c (patch)
tree75e854d9c1b42217fc581cee6bd226d2779389f6
parente4b0f86e1fe38147b0bcf6e50862d0899a31201c (diff)
pg_dump: Set private_date pointer to NULL in callback
The end callback for ZStandard compression frees the private_data but didn't set the pointer to NULL after freeing. This is not a bug as the code is right now, since nothing is dereferencing the pointer upon returning from the callback but it is good practice to do. Author: Alexander Kuznetsov <[email protected]> Reviewed-by: Daniel Gustafsson <[email protected]> Reviewed-by: Ashutosh Bapat <[email protected]> Reviewed-by: Michael Paquier <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/[email protected]
-rw-r--r--src/bin/pg_dump/compress_zstd.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/bin/pg_dump/compress_zstd.c b/src/bin/pg_dump/compress_zstd.c
index 1f7b4942706..cb595b10c2d 100644
--- a/src/bin/pg_dump/compress_zstd.c
+++ b/src/bin/pg_dump/compress_zstd.c
@@ -142,6 +142,7 @@ EndCompressorZstd(ArchiveHandle *AH, CompressorState *cs)
/* output buffer may be allocated in either mode */
pg_free(zstdcs->output.dst);
pg_free(zstdcs);
+ cs->private_data = NULL;
}
static void