summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Paquier2019-08-27 00:11:31 +0000
committerMichael Paquier2019-08-27 00:11:31 +0000
commit9acda731184c1ebdf99172cbb19d0404b7eebc37 (patch)
tree0f6b56acfdf0b8943131e9147461db6990f25d13
parentfb57f40eec503d637bf01c298f5cb2472f0d4fdb (diff)
Fix failure of --jobs with reindexdb and vacuumdb on Windows
FD_SETSIZE needs to be declared before winsock2.h, or it is possible to run into buffer overflow issues when using --jobs. This is similar to pgbench's solution done in a23c641. This has been introduced by 71d84ef, and older versions have been using the default value of FD_SETSIZE, defined at 64. Per buildfarm member jacana, but this impacts all Windows animals running the TAP tests. I have reproduced the failure locally to check the patch. Author: Michael Paquier Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5
-rw-r--r--src/bin/scripts/scripts_parallel.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/bin/scripts/scripts_parallel.c b/src/bin/scripts/scripts_parallel.c
index 55bda9044b4..97435160e95 100644
--- a/src/bin/scripts/scripts_parallel.c
+++ b/src/bin/scripts/scripts_parallel.c
@@ -12,6 +12,10 @@
*-------------------------------------------------------------------------
*/
+#ifdef WIN32
+#define FD_SETSIZE 1024 /* must set before winsock2.h is included */
+#endif
+
#include "postgres_fe.h"
#ifdef HAVE_SYS_SELECT_H