summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndres Freund2023-04-04 01:02:41 +0000
committerAndres Freund2023-04-04 01:02:41 +0000
commit8a2b1b147728b11f6df569081d121b9e3135109d (patch)
treee323e4e7220e4e4dde0d4f4de4a5a381aa6d32a8
parent05a304a855104a8eb6394e044bfbc8e761a4d635 (diff)
bufmgr: Remove buffer-write-dirty tracepoints
The trace point was using the relfileno / fork / block for the to-be-read-in buffer. Some upcoming work would make that more expensive to provide. We still have buffer-flush-start/done, which can serve most tracing needs that buffer-write-dirty could serve. Discussion: https://postgr.es/m/[email protected]
-rw-r--r--doc/src/sgml/monitoring.sgml17
-rw-r--r--src/backend/storage/buffer/bufmgr.c10
-rw-r--r--src/backend/utils/probes.d2
3 files changed, 0 insertions, 29 deletions
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index d5a45f996d0..65da082ed9b 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -7818,23 +7818,6 @@ FROM pg_stat_get_backend_idset() AS backendid;
The arguments are the same as for <literal>buffer-flush-start</literal>.</entry>
</row>
<row>
- <entry><literal>buffer-write-dirty-start</literal></entry>
- <entry><literal>(ForkNumber, BlockNumber, Oid, Oid, Oid)</literal></entry>
- <entry>Probe that fires when a server process begins to write a dirty
- buffer. (If this happens often, it implies that
- <xref linkend="guc-shared-buffers"/> is too
- small or the background writer control parameters need adjustment.)
- arg0 and arg1 contain the fork and block numbers of the page.
- arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
- identifying the relation.</entry>
- </row>
- <row>
- <entry><literal>buffer-write-dirty-done</literal></entry>
- <entry><literal>(ForkNumber, BlockNumber, Oid, Oid, Oid)</literal></entry>
- <entry>Probe that fires when a dirty-buffer write is complete.
- The arguments are the same as for <literal>buffer-write-dirty-start</literal>.</entry>
- </row>
- <row>
<entry><literal>wal-buffer-write-dirty-start</literal></entry>
<entry><literal>()</literal></entry>
<entry>Probe that fires when a server process begins to write a
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index b3adbbe7d23..7f119cd4b0f 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -1280,21 +1280,11 @@ BufferAlloc(SMgrRelation smgr, char relpersistence, ForkNumber forkNum,
}
/* OK, do the I/O */
- TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_START(forkNum, blockNum,
- smgr->smgr_rlocator.locator.spcOid,
- smgr->smgr_rlocator.locator.dbOid,
- smgr->smgr_rlocator.locator.relNumber);
-
FlushBuffer(buf, NULL, IOOBJECT_RELATION, io_context);
LWLockRelease(BufferDescriptorGetContentLock(buf));
ScheduleBufferTagForWriteback(&BackendWritebackContext,
&buf->tag);
-
- TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_DONE(forkNum, blockNum,
- smgr->smgr_rlocator.locator.spcOid,
- smgr->smgr_rlocator.locator.dbOid,
- smgr->smgr_rlocator.locator.relNumber);
}
else
{
diff --git a/src/backend/utils/probes.d b/src/backend/utils/probes.d
index c064d679e94..204a2649b09 100644
--- a/src/backend/utils/probes.d
+++ b/src/backend/utils/probes.d
@@ -66,8 +66,6 @@ provider postgresql {
probe buffer__sync__start(int, int);
probe buffer__sync__written(int);
probe buffer__sync__done(int, int, int);
- probe buffer__write__dirty__start(ForkNumber, BlockNumber, Oid, Oid, Oid);
- probe buffer__write__dirty__done(ForkNumber, BlockNumber, Oid, Oid, Oid);
probe deadlock__found();