summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Eisentraut2023-10-05 06:43:49 +0000
committerPeter Eisentraut2023-10-05 06:45:50 +0000
commit8666cf65ea6926b6d8c781ae03891435131911cd (patch)
treefabc876bf0e1019ae2e2aec83b515243b1d56bbe
parent4f2994647ff1e1209829a0085ca0c8d237dbbbb4 (diff)
Modernize const handling with readline
The comment /* On some platforms, readline is declared as readline(char *) */ is obsolete. The casting away of const can be removed. The const in the readline() prototype was added in GNU readline 4.2, released in 2001. BSD libedit has also had const in the prototype since at least 2001. (The commit that introduced this comment (187e865174) talked about FreeBSD 4.8, which didn't have readline compatibility in libedit yet, so it must have been talking about GNU readline in the base system. This checks out, but already FreeBSD 5 had an updated GNU readline with const.) Reviewed-by: Aleksander Alekseev <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/862fc1d4-9a0c-d2b6-5451-ee3dc750bcab%40eisentraut.org
-rw-r--r--src/bin/psql/input.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/bin/psql/input.c b/src/bin/psql/input.c
index 873d85079c9..7c77fd8e89d 100644
--- a/src/bin/psql/input.c
+++ b/src/bin/psql/input.c
@@ -88,8 +88,7 @@ gets_interactive(const char *prompt, PQExpBuffer query_buf)
/* Enable SIGINT to longjmp to sigint_interrupt_jmp */
sigint_interrupt_enabled = true;
- /* On some platforms, readline is declared as readline(char *) */
- result = readline((char *) prompt);
+ result = readline(prompt);
/* Disable SIGINT again */
sigint_interrupt_enabled = false;