diff options
| author | Amit Kapila | 2025-06-24 04:21:07 +0000 |
|---|---|---|
| committer | Amit Kapila | 2025-06-24 04:21:07 +0000 |
| commit | 6531f36283f05219464dd2084a17aab5747f7de8 (patch) | |
| tree | 799a26aefb19655f679a4f8a6999faeb1ee0909b | |
| parent | fc39b286ad7262a4aac8ff9a34f244763bed7a53 (diff) | |
Fix missing comment update in 1462aad2e4.
Remove the part of comment that says we don't allow toggling two_phase
option as that is supported in commit 1462aad2e4.
Author: Hayato Kuroda <[email protected]>
Author: Amit Kapila <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB1496656725F3951AEE8749EBDF579A@OSCPR01MB14966.jpnprd01.prod.outlook.com
| -rw-r--r-- | src/backend/replication/logical/worker.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c index a23262957ac..fd11805a44c 100644 --- a/src/backend/replication/logical/worker.c +++ b/src/backend/replication/logical/worker.c @@ -109,13 +109,6 @@ * If ever a user needs to be aware of the tri-state value, they can fetch it * from the pg_subscription catalog (see column subtwophasestate). * - * We don't allow to toggle two_phase option of a subscription because it can - * lead to an inconsistent replica. Consider, initially, it was on and we have - * received some prepare then we turn it off, now at commit time the server - * will send the entire transaction data along with the commit. With some more - * analysis, we can allow changing this option from off to on but not sure if - * that alone would be useful. - * * Finally, to avoid problems mentioned in previous paragraphs from any * subsequent (not READY) tablesyncs (need to toggle two_phase option from 'on' * to 'off' and then again back to 'on') there is a restriction for |