summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorÁlvaro Herrera2025-04-05 09:41:01 +0000
committerÁlvaro Herrera2025-04-05 09:41:01 +0000
commit64fba9c61787c98d019c3b5099e21286b61a56d5 (patch)
tree144a18718893060ceaaf13f49ebcd4d3981c1eca
parent4be6a74cfb1ef4c50740e4c2f97a3b478c16de73 (diff)
Set log_statement=none in t/002_pg_upgrade.pl
This should make the test a wee bit faster on high-load machines (e.g., when running under valgrind). Per complaint from Andres Freund. Discussion: https://postgr.es/m/cwbcyjp2ts7o7xgy5y5gwtcd4zltvncsj67el7xgci7xbwrhlu@k363vk5tce4g
-rw-r--r--src/bin/pg_upgrade/t/002_pg_upgrade.pl7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/bin/pg_upgrade/t/002_pg_upgrade.pl b/src/bin/pg_upgrade/t/002_pg_upgrade.pl
index 311391d7acd..78fab48349b 100644
--- a/src/bin/pg_upgrade/t/002_pg_upgrade.pl
+++ b/src/bin/pg_upgrade/t/002_pg_upgrade.pl
@@ -221,6 +221,9 @@ push @old_initdb_params, '-k' if $oldnode->pg_version < 18;
$old_node_params{extra} = \@old_initdb_params;
$oldnode->init(%old_node_params);
+# Override log_statement=all set by Cluster.pm. This avoids large amounts
+# of log traffic that slow this test down even more when run under valgrind.
+$oldnode->append_conf('postgresql.conf', 'log_statement = none');
$oldnode->start;
my $result;
@@ -312,6 +315,8 @@ push @new_initdb_params, ('--encoding', 'SQL_ASCII');
push @new_initdb_params, ('--locale-provider', 'libc');
$new_node_params{extra} = \@new_initdb_params;
$newnode->init(%new_node_params);
+# Avoid unnecessary log noise
+$newnode->append_conf('postgresql.conf', 'log_statement = none');
# Stabilize stats for comparison.
$newnode->append_conf('postgresql.conf', 'autovacuum = off');
@@ -379,6 +384,8 @@ SKIP:
# source cluster to avoid any differences between dumps taken from both the
# clusters caused by differences in their configurations.
$dstnode->init(%old_node_params);
+ # Avoid unnecessary log noise
+ $dstnode->append_conf('postgresql.conf', 'log_statement = none');
# Stabilize stats for comparison.
$dstnode->append_conf('postgresql.conf', 'autovacuum = off');
$dstnode->start;