diff options
| author | Tom Lane | 2022-05-20 17:42:02 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-05-20 17:42:02 +0000 |
| commit | 5e5fa323350060360799004f96840bbf3cb51e49 (patch) | |
| tree | abf6a6fb3339742b3173c7b7a039d1eee691ed24 | |
| parent | 6029861916e8e2c0155c332c10f182a22619c663 (diff) | |
Remove portability hazard in unsafe_tests/sql/guc_privs.sql.
This new-in-v15 test case assumed it could set max_stack_depth as high
as 2MB. You might think that'd be true on any modern platform but
you'd be wrong, as I found out while experimenting with NetBSD/hppa.
This test is about privileges not platform capabilities, so there seems
no need to use any value greater than the 100kB setting already used
in a couple of places in the core regression tests. There's certainly
no call to expect people to raise their platform's default ulimit just
to run this test.
| -rw-r--r-- | src/test/modules/unsafe_tests/expected/guc_privs.out | 4 | ||||
| -rw-r--r-- | src/test/modules/unsafe_tests/sql/guc_privs.sql | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/test/modules/unsafe_tests/expected/guc_privs.out b/src/test/modules/unsafe_tests/expected/guc_privs.out index 58dc87f958e..de4e1b3cdfa 100644 --- a/src/test/modules/unsafe_tests/expected/guc_privs.out +++ b/src/test/modules/unsafe_tests/expected/guc_privs.out @@ -436,9 +436,9 @@ ERROR: parameter "autovacuum_work_mem" cannot be changed now ALTER SYSTEM RESET temp_file_limit; -- ok SET TimeZone = 'Europe/Helsinki'; -- ok RESET TimeZone; -- ok -SET max_stack_depth = 2048; -- ok, privileges have been granted +SET max_stack_depth = '100kB'; -- ok, privileges have been granted RESET max_stack_depth; -- ok, privileges have been granted -ALTER SYSTEM SET max_stack_depth = 2048; -- ok, privileges have been granted +ALTER SYSTEM SET max_stack_depth = '100kB'; -- ok, privileges have been granted ALTER SYSTEM RESET max_stack_depth; -- ok, privileges have been granted SET lc_messages = 'C'; -- fail, insufficient privileges ERROR: permission denied to set parameter "lc_messages" diff --git a/src/test/modules/unsafe_tests/sql/guc_privs.sql b/src/test/modules/unsafe_tests/sql/guc_privs.sql index 12b22548f06..a86b957b9c0 100644 --- a/src/test/modules/unsafe_tests/sql/guc_privs.sql +++ b/src/test/modules/unsafe_tests/sql/guc_privs.sql @@ -176,9 +176,9 @@ SET autovacuum_work_mem = 50; -- cannot be changed now ALTER SYSTEM RESET temp_file_limit; -- ok SET TimeZone = 'Europe/Helsinki'; -- ok RESET TimeZone; -- ok -SET max_stack_depth = 2048; -- ok, privileges have been granted +SET max_stack_depth = '100kB'; -- ok, privileges have been granted RESET max_stack_depth; -- ok, privileges have been granted -ALTER SYSTEM SET max_stack_depth = 2048; -- ok, privileges have been granted +ALTER SYSTEM SET max_stack_depth = '100kB'; -- ok, privileges have been granted ALTER SYSTEM RESET max_stack_depth; -- ok, privileges have been granted SET lc_messages = 'C'; -- fail, insufficient privileges RESET lc_messages; -- fail, insufficient privileges |