summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Munro2022-07-12 04:17:36 +0000
committerThomas Munro2022-07-14 12:06:32 +0000
commit57944910585750b52173a0f67c9e0e42639f1c0a (patch)
tree1f323798a1f29966a5d61583a8445d30fa5bab98
parent7bae3bbf62d63cdd49ae4ca4a851cef0cdbe6ab5 (diff)
Avoid shadowing a variable in sync.c.
It was confusing to reuse the variable name 'entry' in two scopes. Use distinct variable names. Reported-by: Ranier Vilela <[email protected]> Reported-by: Tom Lane <[email protected]> Reported-by: Kyotaro Horiguchi <[email protected]> Discussion: https://postgr.es/m/CAEudQArDrFyQ15Am3rgWBunGBVZFDb90onTS8SRiFAWHeiLiFA%40mail.gmail.com
-rw-r--r--src/backend/storage/sync/sync.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/src/backend/storage/sync/sync.c b/src/backend/storage/sync/sync.c
index e1fb6310038..9d6a9e91090 100644
--- a/src/backend/storage/sync/sync.c
+++ b/src/backend/storage/sync/sync.c
@@ -510,26 +510,26 @@ RememberSyncRequest(const FileTag *ftag, SyncRequestType type)
else if (type == SYNC_FILTER_REQUEST)
{
HASH_SEQ_STATUS hstat;
- PendingFsyncEntry *entry;
+ PendingFsyncEntry *pfe;
ListCell *cell;
/* Cancel matching fsync requests */
hash_seq_init(&hstat, pendingOps);
- while ((entry = (PendingFsyncEntry *) hash_seq_search(&hstat)) != NULL)
+ while ((pfe = (PendingFsyncEntry *) hash_seq_search(&hstat)) != NULL)
{
- if (entry->tag.handler == ftag->handler &&
- syncsw[ftag->handler].sync_filetagmatches(ftag, &entry->tag))
- entry->canceled = true;
+ if (pfe->tag.handler == ftag->handler &&
+ syncsw[ftag->handler].sync_filetagmatches(ftag, &pfe->tag))
+ pfe->canceled = true;
}
/* Cancel matching unlink requests */
foreach(cell, pendingUnlinks)
{
- PendingUnlinkEntry *entry = (PendingUnlinkEntry *) lfirst(cell);
+ PendingUnlinkEntry *pue = (PendingUnlinkEntry *) lfirst(cell);
- if (entry->tag.handler == ftag->handler &&
- syncsw[ftag->handler].sync_filetagmatches(ftag, &entry->tag))
- entry->canceled = true;
+ if (pue->tag.handler == ftag->handler &&
+ syncsw[ftag->handler].sync_filetagmatches(ftag, &pue->tag))
+ pue->canceled = true;
}
}
else if (type == SYNC_UNLINK_REQUEST)