diff options
| author | Bruce Momjian | 2023-11-03 17:57:59 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2023-11-03 17:57:59 +0000 |
| commit | 42d3125adae176cb7dcf7a4d896a78e615f6bbb4 (patch) | |
| tree | f39ca00145dc0be500d530f7dec562094e875327 | |
| parent | d391f6dcc377b961628510ee7049d78032816ac0 (diff) | |
doc: \copy can get data values \. and end-of-input confused
Reported-by: Svante Richter
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 11
| -rw-r--r-- | doc/src/sgml/ref/psql-ref.sgml | 4 | ||||
| -rw-r--r-- | src/bin/psql/copy.c | 2 |
2 files changed, 6 insertions, 0 deletions
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index d94e3cacfcc..cc7d797159b 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -1119,6 +1119,10 @@ INSERT INTO tbl1 VALUES ($1, $2) \bind 'first value' 'second value' \g destination, because all data must pass through the client/server connection. For large amounts of data the <acronym>SQL</acronym> command might be preferable. + Also, because of this pass-through method, <literal>\copy + ... from</literal> in <acronym>CSV</acronym> mode will erroneously + treat a <literal>\.</literal> data value alone on a line as an + end-of-input marker. </para> </tip> diff --git a/src/bin/psql/copy.c b/src/bin/psql/copy.c index b3cc3d9a290..dbbbdb88987 100644 --- a/src/bin/psql/copy.c +++ b/src/bin/psql/copy.c @@ -627,6 +627,8 @@ handleCopyIn(PGconn *conn, FILE *copystream, bool isbinary, PGresult **res) * This code erroneously assumes '\.' on a line alone * inside a quoted CSV string terminates the \copy. * https://www.postgresql.org/message-id/[email protected] + * + * https://www.postgresql.org/message-id/[email protected] */ if ((linelen == 3 && memcmp(fgresult, "\\.\n", 3) == 0) || (linelen == 4 && memcmp(fgresult, "\\.\r\n", 4) == 0)) |