summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2022-06-01 21:21:45 +0000
committerTom Lane2022-06-01 21:21:45 +0000
commitdd1c8dd1015f4548d6c29de56e54eda317b39319 (patch)
tree75683ff69f8de24b6b6d82efa72bd6baf333b68a
parenteb39610f82679e015dd990a3fbba1c62e399c32a (diff)
Silence compiler warnings from some older compilers.
Since a117cebd6, some older gcc versions issue "variable may be used uninitialized in this function" complaints for brin_summarize_range. Silence that using the same coding pattern as in bt_index_check_internal; arguably, a117cebd6 had too narrow a view of which compilers might give trouble. Nathan Bossart and Tom Lane. Back-patch as the previous commit was. Discussion: https://postgr.es/m/20220601163537.GA2331988@nathanxps13
-rw-r--r--contrib/amcheck/verify_nbtree.c2
-rw-r--r--src/backend/access/brin/brin.c6
2 files changed, 7 insertions, 1 deletions
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index a8791000f8..2beeebb163 100644
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -284,7 +284,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed,
else
{
heaprel = NULL;
- /* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */
+ /* Set these just to suppress "uninitialized variable" warnings */
save_userid = InvalidOid;
save_sec_context = -1;
save_nestlevel = -1;
diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index 52f171772d..0de1441dc6 100644
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -1051,7 +1051,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)
save_nestlevel = NewGUCNestLevel();
}
else
+ {
heapRel = NULL;
+ /* Set these just to suppress "uninitialized variable" warnings */
+ save_userid = InvalidOid;
+ save_sec_context = -1;
+ save_nestlevel = -1;
+ }
indexRel = index_open(indexoid, ShareUpdateExclusiveLock);