diff options
author | Andres Freund | 2022-07-18 21:53:02 +0000 |
---|---|---|
committer | Andres Freund | 2022-07-18 21:53:02 +0000 |
commit | d268d0f7a16e9e3c6de660b73543d875b8187def (patch) | |
tree | a313fcf32407ac7a1b88466e22d7ccf1f31e4eba | |
parent | eb6569fd0e24e2f0502ef7b496ba0d3125bd4f15 (diff) |
ecpg: use our instead of my in parse.pl to fix perlcritic complaint
In db0a272d123 I used open(our $something, ...), which perlcritic doesn't
like. It looks like the warning is due to perlcritic knowing about 'my' but
not 'our' when checking for bareword file handles.
However, it's clearly unnecessary to use "our" here, change it to "my".
Via buildfarm member crake and discussion with Tom Lane.
Discussion: https://postgr.es/m/[email protected]
-rw-r--r-- | src/interfaces/ecpg/preproc/parse.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/interfaces/ecpg/preproc/parse.pl b/src/interfaces/ecpg/preproc/parse.pl index a15f563ad4..8fb2224249 100644 --- a/src/interfaces/ecpg/preproc/parse.pl +++ b/src/interfaces/ecpg/preproc/parse.pl @@ -27,8 +27,8 @@ GetOptions( 'parser=s' => \$parser,) or die "wrong arguments"; # open parser / output file early, to raise errors early -open(our $parserfh, '<', $parser) or die "could not open parser file $parser"; -open(our $outfh, '>', $outfile) or die "could not open output file $outfile"; +open(my $parserfh, '<', $parser) or die "could not open parser file $parser"; +open(my $outfh, '>', $outfile) or die "could not open output file $outfile"; my $copymode = 0; my $brace_indent = 0; |