summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmit Kapila2022-06-23 03:53:46 +0000
committerAmit Kapila2022-06-23 03:53:46 +0000
commitac0e2d387a044faed310cbfe2fae78ecb0f6a4b6 (patch)
tree9151e28ac0dc7ab7ae79901bd5735dfed6ee7046
parentca7a0d1d368216e89359c63531a4df0b99a437e4 (diff)
Fix memory leak due to LogicalRepRelMapEntry.attrmap.
When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we forgot to update the related code that frees the attribute map. Author: Hou Zhijie Reviewed-by: Amit Langote, Amit Kapila, Shi yu Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com
-rw-r--r--src/backend/replication/logical/relation.c16
1 files changed, 15 insertions, 1 deletions
diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c
index 46475f3248..e989047681 100644
--- a/src/backend/replication/logical/relation.c
+++ b/src/backend/replication/logical/relation.c
@@ -144,7 +144,7 @@ logicalrep_relmap_free_entry(LogicalRepRelMapEntry *entry)
bms_free(remoterel->attkeys);
if (entry->attrmap)
- pfree(entry->attrmap);
+ free_attrmap(entry->attrmap);
}
/*
@@ -373,6 +373,13 @@ logicalrep_rel_open(LogicalRepRelId remoteid, LOCKMODE lockmode)
int i;
Bitmapset *missingatts;
+ /* Release the no-longer-useful attrmap, if any. */
+ if (entry->attrmap)
+ {
+ free_attrmap(entry->attrmap);
+ entry->attrmap = NULL;
+ }
+
/* Try to find and lock the relation by name. */
relid = RangeVarGetRelid(makeRangeVar(remoterel->nspname,
remoterel->relname, -1),
@@ -620,6 +627,13 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root,
part_entry->partoid = partOid;
}
+ /* Release the no-longer-useful attrmap, if any. */
+ if (entry->attrmap)
+ {
+ free_attrmap(entry->attrmap);
+ entry->attrmap = NULL;
+ }
+
if (!entry->remoterel.remoteid)
{
int i;