summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Gustafsson2021-11-30 13:02:14 +0000
committerDaniel Gustafsson2021-11-30 13:02:14 +0000
commitac0db34e0e5c7ee6f8b5c33c264de3e671fbd4f7 (patch)
treea803eedeba4348319fd8619f2943a8a03cf07d61
parentc113d8ad50d62bfcc16bbd5ceec91122e0046ede (diff)
Remove PF_USED_FOR_ASSERTS_ONLY from variables in general use
fsstate in process_pending_requests (in postgres_fdw.c) was added in 8998e3cafa2 as an assertion-only variable, 1ec7fca8592 stated using the variable outside of assertions. rd_index in get_index_column_opclass (in lsyscache.c) was introduced in 2a6368343ff, and then promptly used in the fix commit 7e041603904 shortly thereafter. This removes the PG_USED_FOR_ASSERTS_ONLY variable decoration from the above mentioned variables. Reviewed-by: Greg Nancarrow <[email protected]> Discussion: https://postgr.es/m/[email protected]
-rw-r--r--contrib/postgres_fdw/postgres_fdw.c2
-rw-r--r--src/backend/utils/cache/lsyscache.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
index f767fdcc6a..fa9a099f13 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -7058,7 +7058,7 @@ void
process_pending_request(AsyncRequest *areq)
{
ForeignScanState *node = (ForeignScanState *) areq->requestee;
- PgFdwScanState *fsstate PG_USED_FOR_ASSERTS_ONLY = (PgFdwScanState *) node->fdw_state;
+ PgFdwScanState *fsstate = (PgFdwScanState *) node->fdw_state;
/* The request would have been pending for a callback */
Assert(areq->callback_pending);
diff --git a/src/backend/utils/cache/lsyscache.c b/src/backend/utils/cache/lsyscache.c
index 4ebaa552a2..9176514a96 100644
--- a/src/backend/utils/cache/lsyscache.c
+++ b/src/backend/utils/cache/lsyscache.c
@@ -3462,7 +3462,7 @@ Oid
get_index_column_opclass(Oid index_oid, int attno)
{
HeapTuple tuple;
- Form_pg_index rd_index PG_USED_FOR_ASSERTS_ONLY;
+ Form_pg_index rd_index;
Datum datum;
bool isnull;
oidvector *indclass;