diff options
| author | Vadim B. Mikheev | 1996-12-14 07:54:22 +0000 |
|---|---|---|
| committer | Vadim B. Mikheev | 1996-12-14 07:54:22 +0000 |
| commit | 8c68e07561a3ac546637a5eecffdd9c9bbbb35d7 (patch) | |
| tree | a45223ddbff1247fdb545c5bd3a1224f9f536eea | |
| parent | 9ec39eb6e38ba7c870c61aacd60c6efcaf4c4abe (diff) | |
Avoiding:
cc1: warnings being treated as errors
datum.c: In function `DatumGetSize':
datum.c:57: warning: unsigned value >= 0 is always 1
gmake[3]: *** [datum.o] Error 1
There was:
if (byVal) {
if (len >= 0 && len <= sizeof(Datum)) {
but len has type Size (unsigned int) and so now there is:
if (byVal) {
if (len <= sizeof(Datum)) {
size = len;
} else {
elog(WARN,
"datumGetSize: Error: type=%ld, byVaL with len=%d",
(long) type, len);
}
} else { /* not byValue */
| -rw-r--r-- | src/backend/utils/adt/datum.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/adt/datum.c b/src/backend/utils/adt/datum.c index 11efd89e7a..c9a49fb5c2 100644 --- a/src/backend/utils/adt/datum.c +++ b/src/backend/utils/adt/datum.c @@ -6,7 +6,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3 1996/11/08 05:59:41 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3.2.1 1996/12/14 07:54:22 vadim Exp $ * *------------------------------------------------------------------------- */ @@ -54,7 +54,7 @@ datumGetSize(Datum value, Oid type, bool byVal, Size len) Size size = 0; if (byVal) { - if (len >= 0 && len <= sizeof(Datum)) { + if (len <= sizeof(Datum)) { size = len; } else { elog(WARN, |