summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2022-11-29 16:46:33 +0000
committerTom Lane2022-11-29 16:46:33 +0000
commit8b47ccb624f8bffc1789fe11769a706c2050f171 (patch)
treed1130845454ed600f8aeb825a402e8f455b41645
parent51dfaa0b010c1efba8a4137cfccd5fbb7f5d4afd (diff)
Prevent clobbering of utility statements in SQL function caches.
This is an oversight in commit 7c337b6b5: I apparently didn't think about the possibility of a SQL function being executed multiple times within a query. In that case, functions.c's primitive caching mechanism allows the same utility parse tree to be presented for execution more than once. We have to tell ProcessUtility to make a working copy of the parse tree, or bad things happen. Normally I'd add a regression test, but I think the reported crasher is dependent on some rather random implementation choices that are nowhere near functions.c, so its usefulness as a long-lived test feels questionable. In any case, this fix is clearly correct given the design choices of 7c337b6b5. Per bug #17702 from Xin Wen. Thanks to Daniel Gustafsson for analysis. Back-patch to v14 where the faulty commit came in (before that, the responsibility for copying scribble-able utility parse trees lay elsewhere). Discussion: https://postgr.es/m/[email protected]
-rw-r--r--src/backend/executor/functions.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c
index e134a82ff7..dc13625171 100644
--- a/src/backend/executor/functions.c
+++ b/src/backend/executor/functions.c
@@ -884,7 +884,7 @@ postquel_getnext(execution_state *es, SQLFunctionCachePtr fcache)
{
ProcessUtility(es->qd->plannedstmt,
fcache->src,
- false,
+ true, /* protect function cache's parsetree */
PROCESS_UTILITY_QUERY,
es->qd->params,
es->qd->queryEnv,