diff options
author | Peter Eisentraut | 2023-03-16 06:37:38 +0000 |
---|---|---|
committer | Peter Eisentraut | 2023-03-16 06:37:38 +0000 |
commit | 4ef1be5a0b676a9f030cc2e4837f4b5650ecb069 (patch) | |
tree | 1356ae2da026043fcd0069690e38d50ff872f7fb | |
parent | e731aeac8928592435f73465a03fae83a2db0ee2 (diff) |
pkg-config Requires.private entries should be comma-separated
In the .pc (pkg-config) files generated by the make and meson builds,
the Requires.private entries use different delimiters. The make build
uses spaces, the meson build uses commas. The pkg-config documentation
says that it should be comma-separated, but apparently about half the
.pc in the wild use just spaces. The pkg-config source code
acknowledges that both commas and spaces work.
This changes the make build to use commas, for consistency.
Reviewed-by: Andres Freund <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/1fb52d61-0964-2d8e-87d9-e8be830e2b24%40enterprisedb.com
-rw-r--r-- | src/interfaces/ecpg/compatlib/Makefile | 2 | ||||
-rw-r--r-- | src/interfaces/ecpg/ecpglib/Makefile | 2 | ||||
-rw-r--r-- | src/interfaces/libpq/Makefile | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/interfaces/ecpg/compatlib/Makefile b/src/interfaces/ecpg/compatlib/Makefile index da470e5418..b9483fba08 100644 --- a/src/interfaces/ecpg/compatlib/Makefile +++ b/src/interfaces/ecpg/compatlib/Makefile @@ -32,7 +32,7 @@ OBJS = \ $(WIN32RES) \ informix.o -PKG_CONFIG_REQUIRES_PRIVATE = libecpg libpgtypes +PKG_CONFIG_REQUIRES_PRIVATE = libecpg, libpgtypes all: all-lib diff --git a/src/interfaces/ecpg/ecpglib/Makefile b/src/interfaces/ecpg/ecpglib/Makefile index 6fadebf53d..652e023405 100644 --- a/src/interfaces/ecpg/ecpglib/Makefile +++ b/src/interfaces/ecpg/ecpglib/Makefile @@ -41,7 +41,7 @@ SHLIB_PREREQS = submake-libpq submake-pgtypeslib SHLIB_EXPORTS = exports.txt -PKG_CONFIG_REQUIRES_PRIVATE = libpq libpgtypes +PKG_CONFIG_REQUIRES_PRIVATE = libpq, libpgtypes all: all-lib diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile index c18e914228..0919d8f32f 100644 --- a/src/interfaces/libpq/Makefile +++ b/src/interfaces/libpq/Makefile @@ -96,7 +96,7 @@ SHLIB_PREREQS = submake-libpgport SHLIB_EXPORTS = exports.txt ifeq ($(with_ssl),openssl) -PKG_CONFIG_REQUIRES_PRIVATE = libssl libcrypto +PKG_CONFIG_REQUIRES_PRIVATE = libssl, libcrypto endif all: all-lib libpq-refs-stamp |