diff options
| author | Tom Lane | 2022-11-19 18:42:53 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-11-19 18:42:53 +0000 |
| commit | 3efc82e28951c6eee24aead056b8478cb424af2e (patch) | |
| tree | a12a4994b3b29dd7b8f677671764ce84ed489e2a | |
| parent | 3b8ad00853cc07456258386c08e683883cd705b3 (diff) | |
Disable debug_discard_caches in test_oat_hooks test.
The test output varies when debug_discard_caches is enabled,
because that causes extra executions of recomputeNamespacePath.
Maybe putting a hook in that was a bad idea, but as a stopgap,
just turn off debug_discard_caches in this test.
Per buildfarm (now that we have debug_discard_caches coverage
again). Back-patch to v15 where this module was added.
Discussion: https://postgr.es/m/[email protected]
| -rw-r--r-- | src/test/modules/test_oat_hooks/expected/test_oat_hooks.out | 4 | ||||
| -rw-r--r-- | src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql | 5 |
2 files changed, 9 insertions, 0 deletions
diff --git a/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out b/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out index b053bc75cc..f80373aecc 100644 --- a/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out +++ b/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out @@ -1,3 +1,7 @@ +-- This test script fails if debug_discard_caches is enabled, because cache +-- flushes cause extra calls of the OAT hook in recomputeNamespacePath, +-- resulting in more NOTICE messages than are in the expected output. +SET debug_discard_caches = 0; -- Creating privileges on a placeholder GUC should create entries in the -- pg_parameter_acl catalog which conservatively grant no privileges to public. CREATE ROLE regress_role_joe; diff --git a/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql b/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql index d0cca8c44e..6b1e500849 100644 --- a/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql +++ b/src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql @@ -1,3 +1,8 @@ +-- This test script fails if debug_discard_caches is enabled, because cache +-- flushes cause extra calls of the OAT hook in recomputeNamespacePath, +-- resulting in more NOTICE messages than are in the expected output. +SET debug_discard_caches = 0; + -- Creating privileges on a placeholder GUC should create entries in the -- pg_parameter_acl catalog which conservatively grant no privileges to public. CREATE ROLE regress_role_joe; |