diff options
| author | Robert Haas | 2017-03-15 11:21:17 +0000 |
|---|---|---|
| committer | Robert Haas | 2017-03-15 11:22:49 +0000 |
| commit | f7b711c8bcef46c67dc5345b983752ac833e51ad (patch) | |
| tree | b9107445fb1fbc6c6fe9a858c248426dddfce551 | |
| parent | aefeb68741fb9456f14b4d690b0c646e532fea6b (diff) | |
Cosmetic fixes for hash index write-ahead logging.
Amit Kapila. One of these was reported by Tom Lane.
Discussion: http://postgr.es/m/[email protected]
| -rw-r--r-- | src/backend/access/hash/README | 3 | ||||
| -rw-r--r-- | src/backend/access/hash/hashpage.c | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/src/backend/access/hash/README b/src/backend/access/hash/README index 00beb86ffa..53b0e0def1 100644 --- a/src/backend/access/hash/README +++ b/src/backend/access/hash/README @@ -365,9 +365,6 @@ try to split the bucket again until the prior split is finished. In other words, a bucket can be in the middle of being split for some time, but it can't be in the middle of two splits at the same time. -Although we can survive a failure to split a bucket, a crash is likely to -corrupt the index, since hash indexes are not yet WAL-logged. - The fourth operation is garbage collection (bulk deletion): next bucket := 0 diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index dc606f162e..622cc4b837 100644 --- a/src/backend/access/hash/hashpage.c +++ b/src/backend/access/hash/hashpage.c @@ -975,7 +975,7 @@ fail: * hash indexes sequentially anyway, that probably doesn't matter. * * XXX It's annoying that this code is executed with the metapage lock held. - * We need to interlock against _hash_getovflpage() adding a new overflow page + * We need to interlock against _hash_addovflpage() adding a new overflow page * concurrently, but it'd likely be better to use LockRelationForExtension * for the purpose. OTOH, adding a splitpoint is a very infrequent operation, * so it may not be worth worrying about. |