summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomas Vondra2017-01-08 21:13:16 +0000
committerTomas Vondra2017-01-08 21:13:16 +0000
commite9805a266afac879b9176249e0e4a02f5b78e442 (patch)
tree3f4628d67dff350a8ae166dc59bdde492633953e
parent0c24122ca5d9b4ab402b6e346a9cbd14b3e91b49 (diff)
make find_push_down_plan/find_delete_push_down_plan static in createplan.c
After upper-planner pathification, optimizer/plan/planner.c no longer needs to tweak plan directly, so restrict those functions lo createplan.c. Eventually, we'll probably pathify XL too, i.e. move all the logic into path construction (i.e. pathnode.c or it's callers).
-rw-r--r--src/backend/optimizer/plan/createplan.c8
-rw-r--r--src/include/optimizer/planmain.h16
2 files changed, 11 insertions, 13 deletions
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
index 7d2a348b0f..4c67a5c541 100644
--- a/src/backend/optimizer/plan/createplan.c
+++ b/src/backend/optimizer/plan/createplan.c
@@ -307,6 +307,10 @@ static int add_sort_column(AttrNumber colIdx, Oid sortOp, Oid coll,
Oid *sortOperators, Oid *collations, bool *nullsFirst);
#endif
+static RemoteSubplan *find_push_down_plan(Plan *plan, bool force);
+static RemoteSubplan *find_delete_push_down_plan(PlannerInfo *root, Plan *plan,
+ bool force, Plan **parent);
+
/*
* create_plan
* Creates the access plan for a query by recursively processing the
@@ -2459,13 +2463,13 @@ find_push_down_plan_int(PlannerInfo *root, Plan *plan, bool force, bool delete,
return NULL;
}
-RemoteSubplan *
+static RemoteSubplan *
find_push_down_plan(Plan *plan, bool force)
{
return find_push_down_plan_int(NULL, plan, force, false, NULL);
}
-RemoteSubplan *
+static RemoteSubplan *
find_delete_push_down_plan(PlannerInfo *root,
Plan *plan,
bool force,
diff --git a/src/include/optimizer/planmain.h b/src/include/optimizer/planmain.h
index 7e26896118..7f96df0beb 100644
--- a/src/include/optimizer/planmain.h
+++ b/src/include/optimizer/planmain.h
@@ -69,6 +69,11 @@ extern Agg *make_agg(List *tlist, List *qual,
double dNumGroups, Plan *lefttree);
extern Limit *make_limit(Plan *lefttree, Node *limitOffset, Node *limitCount,
int64 offset_est, int64 count_est);
+extern RemoteSubplan *make_remotesubplan(PlannerInfo *root,
+ Plan *lefttree,
+ Distribution *resultDistribution,
+ Distribution *execDistribution,
+ List *pathkeys);
/*
* prototypes for plan/initsplan.c
@@ -119,15 +124,4 @@ extern void extract_query_dependencies(Node *query,
List **invalItems,
bool *hasRowSecurity);
-#ifdef PGXC
-extern RemoteSubplan *find_push_down_plan(Plan *plan, bool force);
-extern RemoteSubplan *find_delete_push_down_plan(PlannerInfo *root, Plan *plan,
- bool force, Plan **parent);
-extern RemoteSubplan *make_remotesubplan(PlannerInfo *root,
- Plan *lefttree,
- Distribution *resultDistribution,
- Distribution *execDistribution,
- List *pathkeys);
-#endif /* PGXC */
-
#endif /* PLANMAIN_H */