summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephen Frost2017-07-31 14:37:08 +0000
committerStephen Frost2017-07-31 14:37:08 +0000
commitd2a51e3efcbab5b288bbadba1a7dfa123a50ba5b (patch)
tree9b557f18c07e6c7fa8099e2e85c551358a8772ca
parent393d47ed0f5b764341c7733ef60e8442d3e9bdc2 (diff)
Fix function comment for dumpACL()
The comment for dumpACL() got neglected when initacls and initracls were added and the discussion of what 'racls' is wasn't very clear either. Per complaint from Tom.
-rw-r--r--src/bin/pg_dump/pg_dump.c18
1 files changed, 14 insertions, 4 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 8e9454885a..393b9e25a9 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -14435,10 +14435,20 @@ dumpDefaultACL(Archive *fout, DefaultACLInfo *daclinfo)
* 'tag' is the tag for the archive entry (typ. unquoted name of object).
* 'nspname' is the namespace the object is in (NULL if none).
* 'owner' is the owner, NULL if there is no owner (for languages).
- * 'acls' is the string read out of the fooacl system catalog field;
- * it will be parsed here.
- * 'racls' contains any initial ACLs that the object had which have now been
- * revoked by the user, it will also be parsed here.
+ * 'acls' contains the ACL string of the object from the appropriate system
+ * catalog field; it will be passed to buildACLCommands for building the
+ * appropriate GRANT commands.
+ * 'racls' contains the ACL string of any initial-but-now-revoked ACLs of the
+ * object; it will be passed to buildACLCommands for building the
+ * appropriate REVOKE commands.
+ * 'initacls' In binary-upgrade mode, ACL string of the object's initial
+ * privileges, to be recorded into pg_init_privs
+ * 'initracls' In binary-upgrade mode, ACL string of the object's
+ * revoked-from-default privileges, to be recorded into pg_init_privs
+ *
+ * NB: initacls/initracls are needed because extensions can set privileges on
+ * an object during the extension's script file and we record those into
+ * pg_init_privs as that object's initial privileges.
*----------
*/
static void