diff options
| author | Tom Lane | 2011-09-03 20:17:34 +0000 |
|---|---|---|
| committer | Tom Lane | 2011-09-03 20:17:34 +0000 |
| commit | 48e4b8dc08ea7ec0cc7cd8e5001f8a29e1c0b987 (patch) | |
| tree | f0072405be7a64149007285354aea12adb5bc26b | |
| parent | b3aaf9081a1a95c245fd605dcf02c91b3a5c3a29 (diff) | |
Fix typo in pg_srand48 (srand48 in older branches).
">" should be ">>". This typo results in failure to use all of the bits
of the provided seed.
This might rise to the level of a security bug if we were relying on
srand48 for any security-critical purposes, but we are not --- in fact,
it's not used at all unless the platform lacks srandom(), which is
improbable. Even on such a platform the exposure seems minimal.
Reported privately by Andres Freund.
| -rw-r--r-- | src/port/erand48.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/port/erand48.c b/src/port/erand48.c index 1c0eb467f6..9d471197c3 100644 --- a/src/port/erand48.c +++ b/src/port/erand48.c @@ -96,7 +96,7 @@ pg_srand48(long seed) { _rand48_seed[0] = RAND48_SEED_0; _rand48_seed[1] = (unsigned short) seed; - _rand48_seed[2] = (unsigned short) (seed > 16); + _rand48_seed[2] = (unsigned short) (seed >> 16); _rand48_mult[0] = RAND48_MULT_0; _rand48_mult[1] = RAND48_MULT_1; _rand48_mult[2] = RAND48_MULT_2; |