diff options
author | Guillaume (ioguix) de Rorthais | 2010-05-16 21:47:07 +0000 |
---|---|---|
committer | Guillaume (ioguix) de Rorthais | 2010-05-16 21:47:07 +0000 |
commit | aea1bc3d979b4885f5703f96f24f4db95f78f1b8 (patch) | |
tree | c649e59859e0ea7293f7c568c55ff74900074257 | |
parent | e52672b9a1d8b955779ae2cd24e6be0edd259dec (diff) |
Fix bug reported by Alexey Baturin on admin page + small ergonomy changes
In the "Autovacuum setup per table" section:
* removed useless schema and table column when on a table's admin page
* added links to related schema and table when on a database's admin page
-rw-r--r-- | admin.php | 18 |
1 files changed, 12 insertions, 6 deletions
@@ -522,16 +522,14 @@ // Cluster if ($data->hasRecluster()){ + $disabled = ''; echo "<td class=\"data1\" style=\"text-align: center; vertical-align: bottom\">\n"; echo "<form action=\"{$script}\" method=\"post\">\n"; echo $misc->form; if ($type == 'table') { echo "<input type=\"hidden\" name=\"table\" value=\"", htmlspecialchars($_REQUEST['object']), "\" />\n"; echo "<input type=\"hidden\" name=\"subject\" value=\"table\" />\n"; - if ($data->alreadyClustered($_REQUEST['object'])) { - $disabled = ''; - } - else { + if (!$data->alreadyClustered($_REQUEST['object'])) { $disabled = 'disabled="disabled" '; echo "{$lang['strnoclusteravailable']}<br />"; } @@ -566,7 +564,7 @@ else $autovac = $data->getTableAutovacuum(); echo "<br /><br /><h2>{$lang['strvacuumpertable']}</h2>"; - echo '<p>' . (($defaults->fields['autovacuum'] == 'on') ? $lang['strturnedon'] : $lang['strturnedoff'] ) . '</p>'; + echo '<p>' . (($defaults['autovacuum'] == 'on') ? $lang['strturnedon'] : $lang['strturnedoff'] ) . '</p>'; echo "<p class=\"message\">{$lang['strnotdefaultinred']}</p>"; function enlight($f, $p) { @@ -579,10 +577,14 @@ 'namespace' => array( 'title' => $lang['strschema'], 'field' => field('nspname'), + 'url' => "redirect.php?subject=schema&{$misc->href}&", + 'vars' => array('schema' => 'nspname'), ), 'relname' => array( 'title' => $lang['strtable'], 'field' => field('relname'), + 'url' => "redirect.php?subject=table&{$misc->href}&", + 'vars' => array('table' => 'relname', 'schema' => 'nspname'), ), 'autovacuum_enabled' => array( 'title' => $lang['strenabled'], @@ -644,7 +646,11 @@ ); if ($type == 'table') { - unset($actions['edit']['vars']['schema'], $actions['delete']['vars']['schema']); + unset($actions['edit']['vars']['schema'], + $actions['delete']['vars']['schema'], + $columns['namespace'], + $columns['relname'] + ); } $misc->printTable($autovac, $columns, $actions, $lang['strnovacuumconf']); |