diff options
| author | Magnus Hagander | 2018-12-26 11:52:01 +0000 |
|---|---|---|
| committer | Magnus Hagander | 2018-12-26 11:52:01 +0000 |
| commit | d9a2b88e70ba2fb5755bc330c6dcaee87a6a7ad3 (patch) | |
| tree | a65cca6dcb6335a96dfb18c0d23670e7dfa9ef3a | |
| parent | 535af6e586adae94bdc8502fb78602877345dad8 (diff) | |
Change sort order for reviewers/authors in filter dropdown
Previously it was sorted by last name, which did not always make sense.
Canged to sort by first name, which hopefully makes more sense.
Per request from Alvaro Herrera and others.
| -rw-r--r-- | pgcommitfest/commitfest/forms.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pgcommitfest/commitfest/forms.py b/pgcommitfest/commitfest/forms.py index 29ab2af..568af64 100644 --- a/pgcommitfest/commitfest/forms.py +++ b/pgcommitfest/commitfest/forms.py @@ -28,7 +28,7 @@ class CommitFestFilterForm(forms.Form): self.fields['status'] = forms.ChoiceField(choices=c, required=False) q = Q(patch_author__commitfests=cf) | Q(patch_reviewer__commitfests=cf) - userchoices = [(-1, '* All'), (-2, '* None'), (-3, '* Yourself') ] + [(u.id, '%s %s (%s)' % (u.first_name, u.last_name, u.username)) for u in User.objects.filter(q).distinct().order_by('last_name', 'first_name')] + userchoices = [(-1, '* All'), (-2, '* None'), (-3, '* Yourself') ] + [(u.id, '%s %s (%s)' % (u.first_name, u.last_name, u.username)) for u in User.objects.filter(q).distinct().order_by('first_name', 'last_name')] self.fields['author'] = forms.ChoiceField(choices=userchoices, required=False) self.fields['reviewer'] = forms.ChoiceField(choices=userchoices, required=False) |