summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Haas2009-07-03 03:31:51 +0000
committerRobert Haas2009-07-03 03:31:51 +0000
commit45f4ced80004e2d220c500b7ee0e3d769cfa4356 (patch)
tree2bf5ab832e6f25ce09bd285ba04714b58d2e2f14
parent4a189a0de87434c858dbb81b66220d70491ef8db (diff)
Suggestions from Brendan Jurd.
- Increase default text field size from 40 to 60 and default max size from 40 to 120. - Change secondary sort on commitfest_view page to id.
-rw-r--r--perl-lib/PgCommitFest/CommitFest.pm2
-rw-r--r--perl-lib/PgCommitFest/WebControl.pm4
2 files changed, 3 insertions, 3 deletions
diff --git a/perl-lib/PgCommitFest/CommitFest.pm b/perl-lib/PgCommitFest/CommitFest.pm
index b1b3d8d..06c725a 100644
--- a/perl-lib/PgCommitFest/CommitFest.pm
+++ b/perl-lib/PgCommitFest/CommitFest.pm
@@ -103,7 +103,7 @@ EOM
SELECT id, name, patch_status_id, patch_status, author, reviewers,
commitfest_topic_id, commitfest_topic, commitfest_id, date_closed
FROM patch_view WHERE commitfest_id = ?
- ORDER BY date_closed, commitfest_topic, name
+ ORDER BY date_closed, commitfest_topic, id
EOM
for my $p (@$patch_list) {
if (grep { $_ eq $p->{'patch_status_id'} } qw(4 5 6)) {
diff --git a/perl-lib/PgCommitFest/WebControl.pm b/perl-lib/PgCommitFest/WebControl.pm
index 7f4e48f..6873dcb 100644
--- a/perl-lib/PgCommitFest/WebControl.pm
+++ b/perl-lib/PgCommitFest/WebControl.pm
@@ -132,9 +132,9 @@ sub render {
$self->{'name'},
$self->{'istype'}{'password'} ? 'password' : 'text',
defined $self->{'size'} ? $self->{'size'}
- : ($self->{'istype'}{'date'} ? 10 : 40),
+ : ($self->{'istype'}{'date'} ? 10 : 60),
defined $self->{'maxlength'} ? $self->{'maxlength'}
- : ($self->{'istype'}{'date'} ? 10 : 40),
+ : ($self->{'istype'}{'date'} ? 10 : 120),
$self->{'istype'}{'password'} ? '' : escape($self->{'value'});
}
elsif ($self->{'istype'}{'textarea'}) {