summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg2009-06-03 01:00:12 +0000
committerGreg2009-06-03 01:00:12 +0000
commit175d6f9b269c6b03ddc800fc824dc6b534b54cab (patch)
tree80bc5c0b36820184a148797e62995f7685f13ec5
parentb0f76d33de121c826d3044e30c68b74ef7bc397b (diff)
More Perl::Critic tweaks
-rw-r--r--.perlcriticrc1
-rw-r--r--Makefile.PL2
-rwxr-xr-xcheck_postgres.pl4
3 files changed, 4 insertions, 3 deletions
diff --git a/.perlcriticrc b/.perlcriticrc
index 2645ed9f4..0237e9127 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -38,6 +38,7 @@ stop_words = Mullane Nagios Slony nols salesrep psql dbname postgres USERNAME us
[-Miscellanea::RequireRcsKeywords]
[-Modules::ProhibitExcessMainComplexity]
[-Modules::RequireExplicitInclusion]
+[-Modules::RequireFilenameMatchesPackage]
[-NamingConventions::Capitalization]
[-NamingConventions::ProhibitAmbiguousNames]
[-NamingConventions::ProhibitMixedCaseVars]
diff --git a/Makefile.PL b/Makefile.PL
index b9f79fa67..7ef5a6f00 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -57,7 +57,7 @@ my %opts =
);
{
- package MY; ## no critic
+ package MY;
sub clean { ## no critic (RequireArgUnpacking)
my $string = shift->SUPER::clean(@_);
$string =~ s{\t}{\tperl t/99_cleanup\.t\n\t};
diff --git a/check_postgres.pl b/check_postgres.pl
index a3c60b3e1..3725c4374 100755
--- a/check_postgres.pl
+++ b/check_postgres.pl
@@ -4262,10 +4262,10 @@ sub check_same_schema {
push @{$filter{"no${type}_regex"}} => $1;
}
}
- if ($phrase =~ /^noposition$/io) {
+ if ($phrase =~ /^noposition$/io) { ## no critic (ProhibitFixedStringMatches)
$filter{noposition} = 1;
}
- if ($phrase =~ /^nofuncbody$/io) {
+ if ($phrase =~ /^nofuncbody$/io) { ## no critic (ProhibitFixedStringMatches)
$filter{nofuncbody} = 1;
}
}