summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Sabino Mullane2012-01-17 19:50:04 +0000
committerGreg Sabino Mullane2012-01-17 19:50:04 +0000
commit12a89b9c811790d8946d77429d5b50c6e51c52c3 (patch)
tree2e20b0d317fb02b1e1d4b194dea8cb89ffaed0e6
parentcad00ed5f1475c9f8b225617ba76549280341cac (diff)
Try to wrap failing Perl::Critic calls in an eval. Does not work.
-rw-r--r--t/99_perlcritic.t14
1 files changed, 11 insertions, 3 deletions
diff --git a/t/99_perlcritic.t b/t/99_perlcritic.t
index 3bb7610f0..4a1e449e8 100644
--- a/t/99_perlcritic.t
+++ b/t/99_perlcritic.t
@@ -41,9 +41,17 @@ for my $filename (qw{Makefile.PL check_postgres.pl t/CP_Testing.pm}) {
-e $filename or die qq{Could not find "$filename"!};
open my $oldstderr, '>&', \*STDERR or die 'Could not dupe STDERR';
close STDERR or die qq{Could not close STDERR: $!};
- diag "Running perlcritic on file $filename";
- my @vio = $critic->critique($filename);
- diag "Done";
+ my @vio;
+ my $ranok = 0;
+ eval {
+ @vio = $critic->critique($filename);
+ $ranok = 1;
+ };
+ if (! $ranok) {
+ pass "Perl::Critic failed for file $filename. Error was: $@\n";
+ $@ = undef;
+ next;
+ }
open STDERR, '>&', $oldstderr or die 'Could not recreate STDERR'; ## no critic
close $oldstderr or die qq{Could not close STDERR copy: $!};
my $vios = 0;