meep supports building for MPI, but the current state of the port does not support this configure option. MPI support, however, is very usefull for larger simulations on multi-processor machines. I therefore suggest to add an Option (default: Off) to build the MPI version of meep. Fix: Apply the following patch. Note: - the patch also contains the missing (semantical) gsed-dependency noted in ports/155469; I nevertheless decided to send a new report rather than a follow-up, as this is a new issue with a much larger change-request - while there, the patch also removes MD5 checksum
Maintainer of science/meep, Please note that PR ports/155655 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155655 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thanks for PRs. Both ports/155655 and ports/155469 are good additions to science/meep port. MPI knob should be turned on by deafult, because SMP hosts are cheap enough at 2011 ;-) Here is cumulative patch for them (meep_stast.txt) and patch for science/libctl (workaround for building libctl with libtool via copy-pasting from http://www.freebsd.org/cgi/query-pr.cgi?pr=155105&cat=ports).
Responsible Changed From-To: freebsd-ports-bugs->stephen I'll take this.
Stas, 1. Can you email me again the patch you submitted? It got mangled by GNATS. 2. I appreciate your confidence in copying my proposed solution ports/155105. But I suspect that I'll have to discuss it with the community at large to see if this is acceptable. Thanks, Stephen
stephen 2011-06-21 02:19:07 UTC FreeBSD ports repository Modified files: science/meep Makefile distinfo pkg-plist science/meep/files patch-configure Added files: science/meep/files patch-Makefile.in Log: - Add optional dependency net/openmpi - Add lib_depends textproc/gsed - Make datadir safe - Move pkgconfig from lib to libdata - Make patches to configure prefix friendly PR: ports/155655 Submitted by: Klaus Aehlig <aehlig@linta.de> Approved by: maho (mentor) and Stas Timokhin <devel@stasyan.com> (maintainer) Revision Changes Path 1.5 +31 -11 ports/science/meep/Makefile 1.2 +0 -1 ports/science/meep/distinfo 1.1 +19 -0 ports/science/meep/files/patch-Makefile.in (new) 1.2 +26 -16 ports/science/meep/files/patch-configure 1.2 +12 -8 ports/science/meep/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed changes to meep, with several portlint corrections. Fixing libtool issue is ongoing issue, and so the science/libctl changes are not committed, except that Stas Timokhin is now the maintainer.
Dear Stas, I haven't committed your suggested changes to science/libctl. The libtools issue is ongoing. But I have honored your implicit request to become maintainer of science/libctl. Best regards, Stephen