Re: pg_monitor role description

Hello,

On 20.05.2021 19:03, Tom Lane wrote:

Pavel Luzanov <[email protected]> writes:

Let me try one more time.
What is correct from the English language point of view:
1. Julien Rouhaud is a member of PostgreSQL Community.
or
2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier.
Or both forms are correct?
I think that 1 is correct.

You're right about that ...

So, is it correct to change description of pg_monitor role from:

"Read/execute various monitoring views and functions. This role is a member of pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables."

to

"Read/execute various monitoring views and functions. The roles pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables are members of this role."

I can prepare a simple patch.

And column header in a \du output must be something like 'members' instead of 'member of'.

... but this does not follow, because it's a poor analogy.  "Member of"
means "these role(s) have been GRANT'ed to pg_monitor".

Yes, I understood this point and agree.

-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company