Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Fix pg_get_ruledef() so that negative numeric constants are - Mailing list pgsql-committers

From [email protected] (Tom Lane)
Subject pgsql: Fix pg_get_ruledef() so that negative numeric constants are
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Fix pg_get_ruledef() so that negative numeric constants are parenthesized.
This is needed because :: casting binds more tightly than minus, so for
example -1::integer is not the same as (-1)::integer, and there are cases
where the difference is important.  In particular this caused a failure
in SELECT DISTINCT ... ORDER BY ... where expressions that should have
matched were seen as different by the parser; but I suspect that there
could be other cases where failure to parenthesize leads to subtler
semantic differences in reloaded rules.  Per report from Alexandr Popov.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        ruleutils.c (r1.157.2.6 -> r1.157.2.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.157.2.6&r2=1.157.2.7)

pgsql-committers by date:

Previous
From: [email protected] (Tom Lane)
Date:
Subject: pgsql: Fix pg_get_ruledef() so that negative numeric constants are
Next
From: [email protected] (Alvaro Herrera)
Date:
Subject: pgsql: Change xlog.h to xlogdefs.h in bufpage.h, and fix fallout.