r26979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26978‎ | r26979 | r26980 >
Date:16:11, 27 October 2007
Author:brion
Status:old
Tags:
Comment:
* Don't put _ into the title in the form
* Skip some useless quotes
Modified paths:
  • /trunk/phase3/includes/SpecialWhatlinkshere.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialWhatlinkshere.php
@@ -156,7 +156,7 @@
157157 /* Offset must be an integral. */
158158 if ( !strlen( $options['offset'] ) || !preg_match( '/^[0-9]+$/', $options['offset'] ) )
159159 $options['offset'] = '';
160 - $options['target'] = $this->target->getPrefixedDBkey();
 160+ $options['target'] = $this->target->getPrefixedText();
161161
162162 // Read the rows into an array and remove duplicates
163163 // templatelinks comes second so that the templatelinks row overwrites the
@@ -298,7 +298,7 @@
299299
300300 $options['title'] = $wgTitle->getPrefixedText();
301301
302 - $f = Xml::openElement( 'form', array( 'method' => 'get', 'action' => "$wgScript" ) ) .
 302+ $f = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ) .
303303 Xml::openElement( 'fieldset' ) .
304304 Xml::element( 'legend', array(), wfMsg( 'whatlinkshere' ) ) .
305305 Xml::inputLabel( wfMsg( 'whatlinkshere-page' ), 'target', 'mw-whatlinkshere-target', 40, $options['target'] ) . ' ';

Status & tagging log