postgres-xc-general Mailing List for Postgres-XC

--- 
This message was processed by Kaspersky Mail Gateway 5.6.28/RELEASE running at host imx3.etecsa.cu
Visit our web-site: <http://www.kaspersky.com>, <http://www.viruslist.com>

Hi Ashutosh,

The current code (v1.1) is:

         case T_ArrayRef:
             /*
              * When multiple values of of an array are updated at once
              * FQS planner cannot yet handle SQL representation correctly.
              * So disable FQS in this case and let standard planner 
manage it.
              */
         case T_FieldStore:
             /*
              * PostgreSQL deparsing logic does not handle the FieldStore
              * for more than one fields (see processIndirection()). So, 
let's
              * handle it through standard planner, where whole row will be
              * constructed.
              */
         case T_SetToDefault:
             /*
              * PGXCTODO: we should actually check whether the default 
value to
              * be substituted is shippable to the Datanode. Some cases like
              * nextval() of a sequence can not be shipped to the 
Datanode, hence
              * for now default values can not be shipped to the Datanodes
              */
             pgxc_set_shippability_reason(sc_context, SS_UNSUPPORTED_EXPR);
             pgxc_set_exprtype_shippability(exprType(node), sc_context);
             break;


Sorry, next time I will send a patch.


On 09/10/13 13:24, Ashutosh Bapat wrote:
> Hi Javier,
> What's your change? Can you please provide a patch?
>
>
> On Wed, Oct 9, 2013 at 4:53 PM, Javier Hernandez <jhe...@ce... 
> <mailto:jhe...@ce...>> wrote:
>
>     Hello,
>
>         I am not sure if this is the right mailing list for sending
>     Feature request, if not, sorry for the inconvenience.
>
>         I know you are working on improvements to the planner (Feature
>     Request #95). One important for my project is the ability to use
>     FQS for queries that reference elements in an array column. One
>     example:
>
>         CREATE TABLE TestArray (id SERIAL, flux FLOAT4*[]*, error
>     FLOAT*[]*);
>
>         SELECT flux, error FROM TestArray WHERE id = 12; -- Planner
>     uses FQS
>         SELECT flux[1], error[1] FROM TestArray WHERE id = 12; --
>     Planner uses Remote query and completes in coordinator
>
>         I am beginning to dig in the code and I think I have a
>     temporary solution:
>
>
>     src/backend/optimizer/util/pgxcship.c:709
>
>             case T_ArrayRef:
>                 /*
>                  * When multiple values of of an array are updated at once
>                  * FQS planner cannot yet handle SQL representation
>     correctly.
>                  * So disable FQS in this case and let standard
>     planner manage it.
>                  */
>                 if (sc_context->sc_query != NULL &&
>     sc_context->sc_query->commandType == CMD_SELECT) {
>     pgxc_set_exprtype_shippability(exprType(node), sc_context);
>                 } else {
>     pgxc_set_shippability_reason(sc_context, SS_UNSUPPORTED_EXPR);
>     pgxc_set_exprtype_shippability(exprType(node), sc_context);
>                 }
>                 break;
>
>
>         The original code is always marking the query as
>     SS_UNSUPPORTED_EXPR, but according to the existing comment I think
>     my change is safe for Select. Isn't it?
>
>
>     Thank you very much,
>
>     -- 
>     Javier Hernández
>     Ingeniero de Bases de Datos
>     Centro de Estudios de Fisica del Cosmos de Aragon (ceFca)
>     http://www.cefca.es
>     Plza San Juan Nº 1, Planta 2ª
>     E-44001 Teruel (Spain)
>     Phone: +34 978 221266 Ext.1105
>     Fax:   +34 978 611801
>
>
>     ------------------------------------------------------------------------------
>     October Webinars: Code for Performance
>     Free Intel webinars can help you accelerate application performance.
>     Explore tips for MPI, OpenMP, advanced profiling, and more. Get
>     the most from
>     the latest Intel processors and coprocessors. See abstracts and
>     register >
>     http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
>     _______________________________________________
>     Postgres-xc-general mailing list
>     Pos...@li...
>     <mailto:Pos...@li...>
>     https://lists.sourceforge.net/lists/listinfo/postgres-xc-general
>
>
>
>
> -- 
> Best Wishes,
> Ashutosh Bapat
> EnterpriseDB Corporation
> The Postgres Database Company

Hi Javier,
What's your change? Can you please provide a patch?


On Wed, Oct 9, 2013 at 4:53 PM, Javier Hernandez <jhe...@ce...>wrote:

>  Hello,
>
>     I am not sure if this is the right mailing list for sending Feature
> request, if not, sorry for the inconvenience.
>
>     I know you are working on improvements to the planner (Feature Request
> #95). One important for my project is the ability to use FQS for queries
> that reference elements in an array column. One example:
>
>     CREATE TABLE TestArray (id SERIAL, flux FLOAT4*[]*, error FLOAT*[]*);
>
>     SELECT flux, error FROM TestArray WHERE id = 12; -- Planner uses FQS
>     SELECT flux[1], error[1] FROM TestArray WHERE id = 12; -- Planner uses
> Remote query and completes in coordinator
>
>     I am beginning to dig in the code and I think I have a temporary
> solution:
>
>
> src/backend/optimizer/util/pgxcship.c:709
>
>         case T_ArrayRef:
>             /*
>              * When multiple values of of an array are updated at once
>              * FQS planner cannot yet handle SQL representation correctly.
>              * So disable FQS in this case and let standard planner manage
> it.
>              */
>             if (sc_context->sc_query != NULL &&
> sc_context->sc_query->commandType == CMD_SELECT) {
>                     pgxc_set_exprtype_shippability(exprType(node),
> sc_context);
>             } else {
>                     pgxc_set_shippability_reason(sc_context,
> SS_UNSUPPORTED_EXPR);
>                     pgxc_set_exprtype_shippability(exprType(node),
> sc_context);
>             }
>             break;
>
>
>     The original code is always marking the query as SS_UNSUPPORTED_EXPR,
> but according to the existing comment I think my change is safe for Select.
> Isn't it?
>
>
> Thank you very much,
>
> --
> Javier Hernández
> Ingeniero de Bases de Datos
> Centro de Estudios de Fisica del Cosmos de Aragon (ceFca)http://www.cefca.es
> Plza San Juan Nº 1, Planta 2ª
> E-44001 Teruel (Spain)
> Phone: +34 978 221266 Ext.1105
> Fax:   +34 978 611801
>
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-general mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-general
>
>


-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Hello,

     I am not sure if this is the right mailing list for sending Feature 
request, if not, sorry for the inconvenience.

     I know you are working on improvements to the planner (Feature 
Request #95). One important for my project is the ability to use FQS for 
queries that reference elements in an array column. One example:

     CREATE TABLE TestArray (id SERIAL, flux FLOAT4*[]*, error FLOAT*[]*);

     SELECT flux, error FROM TestArray WHERE id = 12; -- Planner uses FQS
     SELECT flux[1], error[1] FROM TestArray WHERE id = 12; -- Planner 
uses Remote query and completes in coordinator

     I am beginning to dig in the code and I think I have a temporary 
solution:


src/backend/optimizer/util/pgxcship.c:709

         case T_ArrayRef:
             /*
              * When multiple values of of an array are updated at once
              * FQS planner cannot yet handle SQL representation correctly.
              * So disable FQS in this case and let standard planner 
manage it.
              */
             if (sc_context->sc_query != NULL && 
sc_context->sc_query->commandType == CMD_SELECT) {
                     pgxc_set_exprtype_shippability(exprType(node), 
sc_context);
             } else {
                     pgxc_set_shippability_reason(sc_context, 
SS_UNSUPPORTED_EXPR);
                     pgxc_set_exprtype_shippability(exprType(node), 
sc_context);
             }
             break;


     The original code is always marking the query as 
SS_UNSUPPORTED_EXPR, but according to the existing comment I think my 
change is safe for Select. Isn't it?


Thank you very much,

-- 
Javier Hernández
Ingeniero de Bases de Datos
Centro de Estudios de Fisica del Cosmos de Aragon (ceFca)
http://www.cefca.es
Plza San Juan Nº 1, Planta 2ª
E-44001 Teruel (Spain)
Phone: +34 978 221266 Ext.1105
Fax:   +34 978 611801

Year, bit it does provide some command shortcut such as Createdb, Createuser and Psql and yes, bash version used to have Dropdb and Dropuser, although it did not run clean_connection, it was user's responsibility.

Maybe I can create separate pgxc_ctl repo to accommodate such requirements.   So pgxc_ctl will be a kind of separate project, just like many PG contrib modules.

Of course, you can issue separate dropdb and drop user with appropriate -h and -p options.   Dropdb and Dropuser is just a shortcut for this.   I think Psql is useful because it is used very often.   I don't like to type -h/-p each time, rather, I'd like to specify coordinator name if needed.

Any more inputs?
---
Koichi Suzuki

On 2013/10/09, at 13:12, Ashutosh Bapat <ash...@en...<mailto:ash...@en...>> wrote:

Hector,
AFAIK, pgxc_ctl is not an interface for dropping database or user. It's just a cluster management utility. You should use corresponding binaries or SQL commands for that purpose.


On Tue, Oct 8, 2013 at 9:32 PM, Hector M. Jacas <hec...@et...<mailto:hec...@et...>> wrote:

Hi all,

Among the features described in: https://github.com/koichi-szk/PGXC-Tools/blob/master/pgxc_ctl/manual.txt is deleting the databases (Dropdb) and users (Dropuser) and when I try make use of these commands pgxc_ctl answers: command not found

PGXC Createdb testdb
Selected coord2.
PGXC Dropdb testdb
sh: Dropdb: command not found
PGXC Createuser usertest1
Selected coord1.
PGXC Dropuser usertest1
sh: Dropuser: command not found
PGXC

Carefully review the source code and found that in the folder: postgres-xc/contrib/pgxc_ctl , there is a file (do_command.c) in which reference is made and performed the execution of Createdb (line 2339) and Createuser (line 2369).

In this file there is no reference whatsoever to Dropdb or Dropuser .

There is another file (in the same directory) called: pgxc_ctl.bash, in which reference is made and run the corresponding command to Createdb, Dropdb, Createuser and Dropuser.

Do not remember reading during pgxc compliacion and deployment (or pgxc_ctl in the area of contributions ) anything regarding how to handle this situation.

How to resolve this issue?

The pgxc_ctl in its binary version lacks Dropdb and Dropuser commands?
I must choose between the binary version and the version bash? What would be the impact of this change ?

Can anyone guide me please

Thanks in advance,

Hector M. Jacas

---
This message was processed by Kaspersky Mail Gateway 5.6.28/RELEASE running at host imx3.etecsa.cu<http://imx3.etecsa.cu/>
Visit our web-site: <http://www.kaspersky.com<http://www.kaspersky.com/>>, <http://www.viruslist.com<http://www.viruslist.com/>>

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Postgres-xc-general mailing list
Pos...@li...<mailto:Pos...@li...>
https://lists.sourceforge.net/lists/listinfo/postgres-xc-general




--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk_______________________________________________
Postgres-xc-general mailing list
Pos...@li...
https://lists.sourceforge.net/lists/listinfo/postgres-xc-general

Hector,
AFAIK, pgxc_ctl is not an interface for dropping database or user. It's
just a cluster management utility. You should use corresponding binaries or
SQL commands for that purpose.


On Tue, Oct 8, 2013 at 9:32 PM, Hector M. Jacas <hec...@et...>wrote:

>
> Hi all,
>
> Among the features described in: https://github.com/koichi-szk/**
> PGXC-Tools/blob/master/pgxc_**ctl/manual.txt<https://github.com/koichi-szk/PGXC-Tools/blob/master/pgxc_ctl/manual.txt>is deleting the databases (Dropdb) and users (Dropuser) and when I try make
> use of these commands pgxc_ctl answers: command not found
>
> PGXC Createdb testdb
> Selected coord2.
> PGXC Dropdb testdb
> sh: Dropdb: command not found
> PGXC Createuser usertest1
> Selected coord1.
> PGXC Dropuser usertest1
> sh: Dropuser: command not found
> PGXC
>
> Carefully review the source code and found that in the folder:
> postgres-xc/contrib/pgxc_ctl , there is a file (do_command.c) in which
> reference is made and performed the execution of Createdb (line 2339) and
> Createuser (line 2369).
>
> In this file there is no reference whatsoever to Dropdb or Dropuser .
>
> There is another file (in the same directory) called: pgxc_ctl.bash, in
> which reference is made and run the corresponding command to Createdb,
> Dropdb, Createuser and Dropuser.
>
> Do not remember reading during pgxc compliacion and deployment (or
> pgxc_ctl in the area of contributions ) anything regarding how to handle
> this situation.
>
> How to resolve this issue?
>
> The pgxc_ctl in its binary version lacks Dropdb and Dropuser commands?
> I must choose between the binary version and the version bash? What would
> be the impact of this change ?
>
> Can anyone guide me please
>
> Thanks in advance,
>
> Hector M. Jacas
>
> ---
> This message was processed by Kaspersky Mail Gateway 5.6.28/RELEASE
> running at host imx3.etecsa.cu
> Visit our web-site: <http://www.kaspersky.com>, <http://www.viruslist.com>
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
> _______________________________________________
> Postgres-xc-general mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-general
>
>


-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company