postgres-xc-developers Mailing List for Postgres-XC

Hi Michael,

The enclosures are including such files:
1. The patch which fix the bugs about rules you reported.
2. The test cases about mutiple insert.
3. The expect files on insert.sql
4. The test cases on mutiple insert rules.

There're bugs on rule in PGXC, therefore I only attached the test
cases on rule without relative expect file.

Regards,
Benny

2011/2/22 Michael Paquier <mic...@gm...>:
> Hi,
>
> Here is a little bit of feedback about the rule crash.
> I fixed myself an issue I found with rules this morning.
>
> So based on that I ran a couple of tests with your patch.
> 1) case do nothing: works well
> dbt1=# create table aa (a int, b int);
> CREATE TABLE
> dbt1=# create table bb (a int, b int) distribute by replication;
> CREATE TABLE
> dbt1=# create rule aa_ins as on insert to aa do instead nothing;
> CREATE RULE
> dbt1=# insert into aa values (1,2),(2,3);
> INSERT 0 0
> dbt1=# select * from bb;
>  a | b
> ---+---
> (0 rows)
> dbt1=# select * from aa;
>  a | b
> ---+---
> (0 rows)
> This case works well.
>
> 2) with an insert rule: do also
> dbt1=# create table aa (a int, b int);
> CREATE TABLE
> dbt1=# create table bb (a int, b int) distribute by replication;
> CREATE TABLE
> dbt1=# create rule bb_ins as on insert to aa do also insert into bb values
> (new.a,new.b);
> CREATE RULE
> dbt1=# insert into aa values (1,2),(2,3);
> dbt1=# execute direct on node 1 'select * from aa';
>  a | b
> ---+---
>  1 | 2
>  1 | 2
>  2 | 3
>  1 | 2
>  2 | 3
> (5 rows)
> dbt1=# execute direct on node 2 'select * from aa';
>  a | b
> ---+---
>  2 | 3
>  1 | 2
>  2 | 3
>  1 | 2
>  2 | 3
> (5 rows)
> It looks that the query is not running on the good table.
> In RewriteInsertStmt, only one locator information is used when rewriting
> the query.
> Only the locator information of the tables whose rule is applied to is taken
> into account.
>
> For example, in my case queries are not rewritten for table bb but only for
> table aa.
> It may be possible to take into account also the table bb defined in the
> rules when building the lists of values.
>
> If the others have any ideas about how it could be able to do that smoothly,
> any ideas is welcome.
>
> I think you should modify RewriteInsertStmt to take into account also the
> rules that have been fired on this query.
> I suppose this information is visible in the parsing tree as it works well
> for one INSERT value.
>
> I attach a modified version of the patch you sent.
> It does exactly the same thing as your first version.
>
> Regards,
> --
> Michael Paquier
> http://michaelpq.users.sourceforge.net
>
>