postgres-xc-developers Mailing List for Postgres-XC

On Tue, Feb 12, 2013 at 09:49:30AM +0530, Ashutosh Bapat wrote:
> We will leave 1.0 as is, but do this in 1.1?

Why not just adding the prototype for said function in 1.0?

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

On Tue, Feb 12, 2013 at 1:19 PM, Ashutosh Bapat <
ash...@en...> wrote:

> On Mon, Feb 11, 2013 at 8:10 PM, Koichi Suzuki <koi...@gm...>wrote:
>
>> I tested to include postmaster/autovacuum.h both in master and
>> REL1_0_STABLE.   I didn't find any problem in master but found
>> conflicts with other header files in REL1_0_STABLE.
>>
> I am surprised that it actually worked with master... Didn't some of the
backend headers complain about dual dependencies?


>
>> This may be caused by the difference in header files in PG 9.1 and 9.2
>> because gtm.c is the same between these branches.
>>
>>
> Well, you are probably discounting the work Michael did on refactoring the
> GTM code to bring it inline with PG.
>
This is not exactly what I did last November/December, I only cleaned up
the make files, the .so generated and some crazy internal dependencies that
existing between the GTM subfolders. Currently, GTM code has still many
duplications with Postgres src/backend.
-- 
Michael

Thanks Ashutosh for the comment.

Yes, I understand leaving 1.0 as is will be okay.     Please let me
fix the master first, leave a comment on the bug tracker and wait for
a while (maybe a couple of days).   If I don't have any more inputs, I
will close the bug and leave 1.0 as is.    It may be much better than
importing function definitions manually.

Regards;
----------
Koichi Suzuki


2013/2/12 Ashutosh Bapat <ash...@en...>:
>
>
> On Mon, Feb 11, 2013 at 8:10 PM, Koichi Suzuki <koi...@gm...>
> wrote:
>>
>> I tested to include postmaster/autovacuum.h both in master and
>> REL1_0_STABLE.   I didn't find any problem in master but found
>> conflicts with other header files in REL1_0_STABLE.
>>
>> This may be caused by the difference in header files in PG 9.1 and 9.2
>> because gtm.c is the same between these branches.
>>
>
> Well, you are probably discounting the work Michael did on refactoring the
> GTM code to bring it inline with PG.
>
>>
>> Maybe for 1.0, we need to borrow the definition of these functions and
>> code directly.
>
>
> We will leave 1.0 as is, but do this in 1.1?
>
>>
>> ----------
>> Koichi Suzuki
>>
>>
>> 2013/2/11 Koichi Suzuki <koi...@gm...>:
>> > Michael;
>> >
>> > Thanks for pointing this out.   I opened a bug ticket for it and will
>> > commit the fix ASAP.    I understand there's many more to fix WARNINGS
>> > at compilation and we should fix them (with some exception, of
>> > course).
>> >
>> > This will be
>> > ----------
>> > Koichi Suzuki
>> >
>> >
>> > 2013/2/11 Michael Meskes <me...@po...>:
>> >> Hi,
>> >>
>> >> shouldn't src/backend/access/transam/gtm.c include
>> >> "postmaster/autovacuum.h"?
>> >> Without it IsAutoVacuumLauncherProcess() is implicitely defined there.
>> >>
>> >> Michael
>> >> --
>> >> Michael Meskes
>> >> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
>> >> Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
>> >> Jabber: michael.meskes at gmail dot com
>> >> VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux,
>> >> PostgreSQL
>> >>
>> >>
>> >> ------------------------------------------------------------------------------
>> >> Free Next-Gen Firewall Hardware Offer
>> >> Buy your Sophos next-gen firewall before the end March 2013
>> >> and get the hardware for free! Learn more.
>> >> http://p.sf.net/sfu/sophos-d2d-feb
>> >> _______________________________________________
>> >> Postgres-xc-developers mailing list
>> >> Pos...@li...
>> >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>> ------------------------------------------------------------------------------
>> Free Next-Gen Firewall Hardware Offer
>> Buy your Sophos next-gen firewall before the end March 2013
>> and get the hardware for free! Learn more.
>> http://p.sf.net/sfu/sophos-d2d-feb
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Enterprise Postgres Company

On Mon, Feb 11, 2013 at 8:10 PM, Koichi Suzuki <koi...@gm...>wrote:

> I tested to include postmaster/autovacuum.h both in master and
> REL1_0_STABLE.   I didn't find any problem in master but found
> conflicts with other header files in REL1_0_STABLE.
>
> This may be caused by the difference in header files in PG 9.1 and 9.2
> because gtm.c is the same between these branches.
>
>
Well, you are probably discounting the work Michael did on refactoring the
GTM code to bring it inline with PG.


> Maybe for 1.0, we need to borrow the definition of these functions and
> code directly.
>

We will leave 1.0 as is, but do this in 1.1?


> ----------
> Koichi Suzuki
>
>
> 2013/2/11 Koichi Suzuki <koi...@gm...>:
> > Michael;
> >
> > Thanks for pointing this out.   I opened a bug ticket for it and will
> > commit the fix ASAP.    I understand there's many more to fix WARNINGS
> > at compilation and we should fix them (with some exception, of
> > course).
> >
> > This will be
> > ----------
> > Koichi Suzuki
> >
> >
> > 2013/2/11 Michael Meskes <me...@po...>:
> >> Hi,
> >>
> >> shouldn't src/backend/access/transam/gtm.c include
> "postmaster/autovacuum.h"?
> >> Without it IsAutoVacuumLauncherProcess() is implicitely defined there.
> >>
> >> Michael
> >> --
> >> Michael Meskes
> >> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
> >> Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
> >> Jabber: michael.meskes at gmail dot com
> >> VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
> >>
> >>
> ------------------------------------------------------------------------------
> >> Free Next-Gen Firewall Hardware Offer
> >> Buy your Sophos next-gen firewall before the end March 2013
> >> and get the hardware for free! Learn more.
> >> http://p.sf.net/sfu/sophos-d2d-feb
> >> _______________________________________________
> >> Postgres-xc-developers mailing list
> >> Pos...@li...
> >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>
> ------------------------------------------------------------------------------
> Free Next-Gen Firewall Hardware Offer
> Buy your Sophos next-gen firewall before the end March 2013
> and get the hardware for free! Learn more.
> http://p.sf.net/sfu/sophos-d2d-feb
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company