postgres-xc-developers Mailing List for Postgres-XC (Page 3)

Looks OK for me too.

On Thu, Aug 4, 2011 at 7:10 PM, Koichi Suzuki <koi...@gm...> wrote:

> Thanks.   I'll commit the changes when I have Michael's comment.
> ----------
> Koichi Suzuki
>
>
>
> 2011/8/4 Ashutosh Bapat <ash...@en...>:
> > HAVING related changes look OK.
> >
> > On Thu, Aug 4, 2011 at 2:28 PM, Koichi Suzuki <ko...@in...>
> > wrote:
> >>
> >> Attached is a patch to include HAVING and TEMP objects.
> >>
> >> Please let me know if there're any other document files affected by
> these
> >> changes.
> >> ---
> >> Koichi Suzuki
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> >> The must-attend event for mobile developers. Connect with experts.
> >> Get tools for creating Super Apps. See the latest technologies.
> >> Sessions, hands-on labs, demos & much more. Register early & save!
> >> http://p.sf.net/sfu/rim-blackberry-1
> >> _______________________________________________
> >> Postgres-xc-developers mailing list
> >> Pos...@li...
> >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
> >>
> >
> >
> >
> > --
> > Best Wishes,
> > Ashutosh Bapat
> > EntepriseDB Corporation
> > The Enterprise Postgres Company
> >
> >
>
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>



-- 
Michael Paquier
http://michael.otacoo.com

There are no restrictions. All their options are implemented.
And it is possible to create replicated, distributed, modulo and round robin
tables that are temporary.

On Thu, Aug 4, 2011 at 4:58 PM, Koichi Suzuki <koi...@gm...> wrote:

> Okay.   Because CREATE TEMPORARY TABLE does not work in previous
> version, I modified the reference manual not to include this.   Can I
> restore all the original syntax and description on TEMP table/view?
> Are there any restriction on them?
>
> Regards;
> ----------
> Koichi Suzuki
>
>
>
> 2011/8/4 Michael Paquier <mic...@gm...>:
> > I don't get it. The SQL grammar for temporary tables is the one already
> used
> > by postgresql.
> > There is no need to touch gram.y.
> >
> > On Thu, Aug 4, 2011 at 2:47 PM, Koichi Suzuki <koi...@gm...>
> wrote:
> >>
> >> I'm afraid that it does not contain gram.y patch to allow CREATE TEMP
> >> TABLE.   Isn't it a part of this patch?  Or do you suppose this should
> >> be done separately?
> >> ----------
> >> Koichi Suzuki
> >
> > --
> > Michael Paquier
> > http://michael.otacoo.com
> >
>



-- 
Michael Paquier
http://michael.otacoo.com

Thanks.   I'll commit the changes when I have Michael's comment.
----------
Koichi Suzuki



2011/8/4 Ashutosh Bapat <ash...@en...>:
> HAVING related changes look OK.
>
> On Thu, Aug 4, 2011 at 2:28 PM, Koichi Suzuki <ko...@in...>
> wrote:
>>
>> Attached is a patch to include HAVING and TEMP objects.
>>
>> Please let me know if there're any other document files affected by these
>> changes.
>> ---
>> Koichi Suzuki
>>
>>
>> ------------------------------------------------------------------------------
>> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
>> The must-attend event for mobile developers. Connect with experts.
>> Get tools for creating Super Apps. See the latest technologies.
>> Sessions, hands-on labs, demos & much more. Register early & save!
>> http://p.sf.net/sfu/rim-blackberry-1
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Enterprise Postgres Company
>
>

HAVING related changes look OK.

On Thu, Aug 4, 2011 at 2:28 PM, Koichi Suzuki <ko...@in...>wrote:

> Attached is a patch to include HAVING and TEMP objects.
>
> Please let me know if there're any other document files affected by these
> changes.
> ---
> Koichi Suzuki
>
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Attached is a patch to include HAVING and TEMP objects.

Please let me know if there're any other document files affected by these changes.
---
Koichi Suzuki

Okay.   Because CREATE TEMPORARY TABLE does not work in previous
version, I modified the reference manual not to include this.   Can I
restore all the original syntax and description on TEMP table/view?
Are there any restriction on them?

Regards;
----------
Koichi Suzuki



2011/8/4 Michael Paquier <mic...@gm...>:
> I don't get it. The SQL grammar for temporary tables is the one already used
> by postgresql.
> There is no need to touch gram.y.
>
> On Thu, Aug 4, 2011 at 2:47 PM, Koichi Suzuki <koi...@gm...> wrote:
>>
>> I'm afraid that it does not contain gram.y patch to allow CREATE TEMP
>> TABLE.   Isn't it a part of this patch?  Or do you suppose this should
>> be done separately?
>> ----------
>> Koichi Suzuki
>
> --
> Michael Paquier
> http://michael.otacoo.com
>

I don't get it. The SQL grammar for temporary tables is the one already used
by postgresql.
There is no need to touch gram.y.

On Thu, Aug 4, 2011 at 2:47 PM, Koichi Suzuki <koi...@gm...> wrote:

> I'm afraid that it does not contain gram.y patch to allow CREATE TEMP
> TABLE.   Isn't it a part of this patch?  Or do you suppose this should
> be done separately?
> ----------
> Koichi Suzuki
>
-- 
Michael Paquier
http://michael.otacoo.com

I'm afraid that it does not contain gram.y patch to allow CREATE TEMP
TABLE.   Isn't it a part of this patch?  Or do you suppose this should
be done separately?
----------
Koichi Suzuki



2011/8/4 Michael Paquier <mic...@gm...>:
> Hi all,
>
> Here is the finalized version of the patch.
> It includes new regression tests dedicated to the joins between temporary
> tables and persistent tables.
> If there are no objections, I'd like to commit that.
>
> Regards,
> --
> Michael Paquier
> http://michael.otacoo.com
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>

Hi all,

Here is the finalized version of the patch.
It includes new regression tests dedicated to the joins between temporary
tables and persistent tables.
If there are no objections, I'd like to commit that.

Regards,
-- 
Michael Paquier
http://michael.otacoo.com

OK I see.
I will add test cases for temp tables in the same commit.
-- 
Michael Paquier
http://michael.otacoo.com

On Wed, Aug 3, 2011 at 4:32 PM, Michael Paquier
<mic...@gm...>wrote:

> Thanks for your time.
> I will try to add some comments in the code to make it more understandable.
>

More the comments the better. But, I think, I didn't understand the code
because I am not familiar with the code. Your comments as they are may be
enough for somebody who knows this code well.


>
> About the test, OK, I understand.
> May I add test cases in this patch or with a separate commit?
> This patch is pretty huge now.
> It may be better to separate things.


Adding tests in the same commit ensures, that in case we revert the commit,
we revert the testcases as well, and regression is unaffected. The downside
is the commit size is large. If we add the testcases in separate commit, we
have to remember to point those two commits to each other and revert both at
a time, in case needed.


>
>
> On Wed, Aug 3, 2011 at 5:02 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Michael,
>> I have looked at the patch. I don't understand this code much. But, may be
>> for building confidence, you may want to add a test with queries involving
>> various combinations of persistent tables, replicated and distributed and
>> temporary tables, esp joining rows across temporary and persistent tables
>> across various datanodes.
>>
>> On Wed, Aug 3, 2011 at 8:14 AM, Michael Paquier <
>> mic...@gm...> wrote:
>>
>>> Hi all,
>>>
>>> Please find attached a patch for the support of temporary tables and
>>> views.
>>> The patch is stabilized for regressions and has no impact on DBT-1
>>> performance.
>>> Besides, this patch contains the whole set of functionalities that can be
>>> applied on a temporary object (index, rename, etc.).
>>>
>>> After enabling temporary tables, I found an issue related to test case
>>> rowtypes on which it is possible to crash the server.
>>> As this is not directly to temporary table but to the test case it
>>> applies on, I will fill in a bug report after committing this patch.
>>> This special query crashing the server is disabled for the moment, as the
>>> rest of the test runs normally.
>>>
>>> Regards,
>>> --
>>> Michael Paquier
>>> http://michael.otacoo.com
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
>>> The must-attend event for mobile developers. Connect with experts.
>>> Get tools for creating Super Apps. See the latest technologies.
>>> Sessions, hands-on labs, demos & much more. Register early & save!
>>> http://p.sf.net/sfu/rim-blackberry-1
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Enterprise Postgres Company
>>
>>
>
>
> --
> Michael Paquier
> http://michael.otacoo.com
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Thanks for your time.
I will try to add some comments in the code to make it more understandable.

About the test, OK, I understand.
May I add test cases in this patch or with a separate commit?
This patch is pretty huge now.
It may be better to separate things.

On Wed, Aug 3, 2011 at 5:02 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Michael,
> I have looked at the patch. I don't understand this code much. But, may be
> for building confidence, you may want to add a test with queries involving
> various combinations of persistent tables, replicated and distributed and
> temporary tables, esp joining rows across temporary and persistent tables
> across various datanodes.
>
> On Wed, Aug 3, 2011 at 8:14 AM, Michael Paquier <mic...@gm...
> > wrote:
>
>> Hi all,
>>
>> Please find attached a patch for the support of temporary tables and
>> views.
>> The patch is stabilized for regressions and has no impact on DBT-1
>> performance.
>> Besides, this patch contains the whole set of functionalities that can be
>> applied on a temporary object (index, rename, etc.).
>>
>> After enabling temporary tables, I found an issue related to test case
>> rowtypes on which it is possible to crash the server.
>> As this is not directly to temporary table but to the test case it applies
>> on, I will fill in a bug report after committing this patch.
>> This special query crashing the server is disabled for the moment, as the
>> rest of the test runs normally.
>>
>> Regards,
>> --
>> Michael Paquier
>> http://michael.otacoo.com
>>
>>
>> ------------------------------------------------------------------------------
>> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
>> The must-attend event for mobile developers. Connect with experts.
>> Get tools for creating Super Apps. See the latest technologies.
>> Sessions, hands-on labs, demos & much more. Register early & save!
>> http://p.sf.net/sfu/rim-blackberry-1
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Enterprise Postgres Company
>
>


-- 
Michael Paquier
http://michael.otacoo.com

Hi Michael,
I have looked at the patch. I don't understand this code much. But, may be
for building confidence, you may want to add a test with queries involving
various combinations of persistent tables, replicated and distributed and
temporary tables, esp joining rows across temporary and persistent tables
across various datanodes.

On Wed, Aug 3, 2011 at 8:14 AM, Michael Paquier
<mic...@gm...>wrote:

> Hi all,
>
> Please find attached a patch for the support of temporary tables and views.
> The patch is stabilized for regressions and has no impact on DBT-1
> performance.
> Besides, this patch contains the whole set of functionalities that can be
> applied on a temporary object (index, rename, etc.).
>
> After enabling temporary tables, I found an issue related to test case
> rowtypes on which it is possible to crash the server.
> As this is not directly to temporary table but to the test case it applies
> on, I will fill in a bug report after committing this patch.
> This special query crashing the server is disabled for the moment, as the
> rest of the test runs normally.
>
> Regards,
> --
> Michael Paquier
> http://michael.otacoo.com
>
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Excellent Work!

You've saved almost one month.
---
Koichi Suzuki

On Wed, 3 Aug 2011 11:44:17 +0900
Michael Paquier <mic...@gm...> wrote:

> Hi all,
> 
> Please find attached a patch for the support of temporary tables and views.
> The patch is stabilized for regressions and has no impact on DBT-1
> performance.
> Besides, this patch contains the whole set of functionalities that can be
> applied on a temporary object (index, rename, etc.).
> 
> After enabling temporary tables, I found an issue related to test case
> rowtypes on which it is possible to crash the server.
> As this is not directly to temporary table but to the test case it applies
> on, I will fill in a bug report after committing this patch.
> This special query crashing the server is disabled for the moment, as the
> rest of the test runs normally.
> 
> Regards,
> -- 
> Michael Paquier
> http://michael.otacoo.com

Hi all,

Please find attached a patch for the support of temporary tables and views.
The patch is stabilized for regressions and has no impact on DBT-1
performance.
Besides, this patch contains the whole set of functionalities that can be
applied on a temporary object (index, rename, etc.).

After enabling temporary tables, I found an issue related to test case
rowtypes on which it is possible to crash the server.
As this is not directly to temporary table but to the test case it applies
on, I will fill in a bug report after committing this patch.
This special query crashing the server is disabled for the moment, as the
rest of the test runs normally.

Regards,
-- 
Michael Paquier
http://michael.otacoo.com