postgres-xc-committers Mailing List for Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  e688e8c9c9e02016fbfb0f8c6fb1c45a81b4373d (commit)
      from  4f610fa74394eb379a3baf3fdd0ea9c722ead3b2 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=e688e8c9c9e02016fbfb0f8c6fb1c45a81b4373d

commit e688e8c9c9e02016fbfb0f8c6fb1c45a81b4373d
Author: Abbas <abb...@en...>
Date:   Thu Jun 6 07:08:13 2013 +0500

    Fix handling of number of tuples processed
    
    Problem:
    Currently the number of tuples processed is updated in
    both HandleCommandComplete and ExecInsert/Update/Delete.
    
    In HandleCommandComplete() it gets it from the command tag
    returned from the datanode i.e. INSERT 0 2, UPDATE 5 and likewise.
    And then it updates estate->es_processed. But it does this only
    for FQS. For non-FQS, in ExecInsert/Update,  it is just incremented
    by 1. So if a trigger function skips one row on datanode,
    the command tag returned from datanode is INSERT 0 0.
    But still in ExecInsert() increments the row count.
    
    Solution:
    Add a new field RemoteQueryState->rqs_processed, which is updated
    in HandleCommandComplete(). Then it is used in ExecInsert/Update/Delete()
    for non-FQS, and in RemoteQueryNext() for FQS.
    
    Patch By Amit Khandekar
    I just reviewed the patch, did a minor fix and committed the patch.

M	src/backend/executor/nodeModifyTable.c
M	src/backend/pgxc/pool/execRemote.c
M	src/include/pgxc/execRemote.h
M	src/test/regress/expected/xc_returning.out
M	src/test/regress/expected/xc_trigship.out
M	src/test/regress/sql/xc_returning.sql
M	src/test/regress/sql/xc_trigship.sql

-----------------------------------------------------------------------

Summary of changes:
 src/backend/executor/nodeModifyTable.c     |   79 ++++---------------------
 src/backend/pgxc/pool/execRemote.c         |   86 +++++++++++++++++-----------
 src/include/pgxc/execRemote.h              |    4 +-
 src/test/regress/expected/xc_returning.out |   45 ++++++++++++++
 src/test/regress/expected/xc_trigship.out  |   55 ++++++++++++++++++
 src/test/regress/sql/xc_returning.sql      |   39 +++++++++++++
 src/test/regress/sql/xc_trigship.sql       |    1 +
 7 files changed, 205 insertions(+), 104 deletions(-)


hooks/post-receive
-- 
Postgres-XC