postgres-xc-committers Mailing List for Postgres-XC

Thanks Abbas.

----------
Koichi Suzuki


2013/1/24 Abbas Butt <abb...@en...>:
>
>
> On Thu, Jan 24, 2013 at 1:34 PM, Koichi Suzuki <koi...@gm...>
> wrote:
>>
>> Thanks a lot Abbas;
>>
>> This has been very tough work.   It's very valuable because it is the
>> fundamentals for triggers and global constraints.
>>
>> Because it passed long review process, the code is great.   Please let
>> me have one question:  Are there any modification to reference
>> document?
>
>
> Yes there will be changes to the documentation, I will submit the patch for
> that as soon as I finish the Query structure usage in DML planning work.
>
>
>>
>>   If there's some restrictions, I think we should include
>> this.
>
>
> Currently there is not restriction but there are a few things the user needs
> to know when using DMLs on replicated tables with RETURNING. I will try to
> cover them in the documentation changes.
>
>>
>>
>> Regards;
>> ----------
>> Koichi Suzuki
>>
>>
>> 2013/1/23 Abbas Butt <ga...@us...>:
>> > Project "Postgres-XC".
>> >
>> > The branch, master has been updated
>> >        via  f4a3652271d80627dcc28171eeccd7620ad397c7 (commit)
>> >       from  e4279c68e3db231511025d4f2115fd459a3398ce (commit)
>> >
>> >
>> > - Log -----------------------------------------------------------------
>> >
>> > http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=f4a3652271d80627dcc28171eeccd7620ad397c7
>> >
>> > commit f4a3652271d80627dcc28171eeccd7620ad397c7
>> > Author: Abbas <abb...@en...>
>> > Date:   Wed Jan 23 13:53:14 2013 +0500
>> >
>> >     Add support for RETURNING clause in DMLs
>> >
>> >     The patch does the following major changes
>> >
>> >     1. Modifies the DML planning code to send the shippable part
>> >        of the returning list to the datanodes in the remote query.
>> >     2. Modifies the var references in returning list according to
>> >        the target list that was sent to the datanodes since the
>> >        tuples returned from the datanodes will contain vars in
>> >        that order.
>> >     3. Modifies remote query execution to make sure that a single
>> >        response is accepted in case of DMLs on replicated tables
>> >        with returning lists.
>> >     4. Manages the fact that a DML can return tuples during remote
>> >        query execution.
>> >     5. Manages null tuples received from datanodes while counting
>> >        modified tuples.
>> >     6. Uses projection mechanism to show returned tuples
>> >     7. Adds test cases.
>> >
>> >     Special thanks to Ashutosh for reviewing the patch.
>> >
>> > M       src/backend/executor/nodeModifyTable.c
>> > M       src/backend/optimizer/plan/pgxcplan.c
>> > M       src/backend/optimizer/plan/setrefs.c
>> > M       src/backend/optimizer/util/pgxcship.c
>> > M       src/backend/parser/parse_relation.c
>> > M       src/backend/pgxc/pool/execRemote.c
>> > M       src/backend/utils/adt/ruleutils.c
>> > M       src/include/pgxc/execRemote.h
>> > M       src/include/utils/builtins.h
>> > M       src/test/regress/expected/plpgsql_1.out
>> > M       src/test/regress/expected/rangefuncs_1.out
>> > M       src/test/regress/expected/returning_1.out
>> > M       src/test/regress/expected/triggers_1.out
>> > M       src/test/regress/expected/with.out
>> > M       src/test/regress/expected/xc_create_function.out
>> > A       src/test/regress/expected/xc_returning.out
>> > M       src/test/regress/parallel_schedule
>> > M       src/test/regress/serial_schedule
>> > M       src/test/regress/sql/returning.sql
>> > M       src/test/regress/sql/with.sql
>> > M       src/test/regress/sql/xc_create_function.sql
>> > A       src/test/regress/sql/xc_returning.sql
>> >
>> > -----------------------------------------------------------------------
>> >
>> > Summary of changes:
>> >  src/backend/executor/nodeModifyTable.c           |  127 ++-
>> >  src/backend/optimizer/plan/pgxcplan.c            |  125 ++-
>> >  src/backend/optimizer/plan/setrefs.c             |  141 +++-
>> >  src/backend/optimizer/util/pgxcship.c            |    4 +
>> >  src/backend/parser/parse_relation.c              |    7 -
>> >  src/backend/pgxc/pool/execRemote.c               |  303 ++++-
>> >  src/backend/utils/adt/ruleutils.c                |   33 +
>> >  src/include/pgxc/execRemote.h                    |    5 +-
>> >  src/include/utils/builtins.h                     |    1 +
>> >  src/test/regress/expected/plpgsql_1.out          |   42 +-
>> >  src/test/regress/expected/rangefuncs_1.out       |  178 +++-
>> >  src/test/regress/expected/returning_1.out        |  269 +++--
>> >  src/test/regress/expected/triggers_1.out         |   12 +-
>> >  src/test/regress/expected/with.out               |  512 +++++++--
>> >  src/test/regress/expected/xc_create_function.out |   23 +-
>> >  src/test/regress/expected/xc_returning.out       | 1324
>> > ++++++++++++++++++++++
>> >  src/test/regress/parallel_schedule               |    3 +-
>> >  src/test/regress/serial_schedule                 |    1 +
>> >  src/test/regress/sql/returning.sql               |   18 +-
>> >  src/test/regress/sql/with.sql                    |   18 +-
>> >  src/test/regress/sql/xc_create_function.sql      |   24 +-
>> >  src/test/regress/sql/xc_returning.sql            | 1006
>> > ++++++++++++++++
>> >  22 files changed, 3834 insertions(+), 342 deletions(-)
>> >  create mode 100644 src/test/regress/expected/xc_returning.out
>> >  create mode 100644 src/test/regress/sql/xc_returning.sql
>> >
>> >
>> > hooks/post-receive
>> > --
>> > Postgres-XC
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
>> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
>> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
>> > MVPs and experts. ON SALE this month only -- learn more at:
>> > http://p.sf.net/sfu/learnnow-d2d
>> > _______________________________________________
>> > Postgres-xc-committers mailing list
>> > Pos...@li...
>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>
>
>
>
> --
> --
> Abbas
> Architect
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
> Phone: 92-334-5100153
>
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of
> the individual or entity to whom it is addressed. This message
> contains information from EnterpriseDB Corporation that may be
> privileged, confidential, or exempt from disclosure under applicable
> law. If you are not the intended recipient or authorized to receive
> this for the intended recipient, any use, dissemination, distribution,
> retention, archiving, or copying of this communication is strictly
> prohibited. If you have received this e-mail in error, please notify
> the sender immediately by reply e-mail and delete this message.

On Thu, Jan 24, 2013 at 1:34 PM, Koichi Suzuki <koi...@gm...>wrote:

> Thanks a lot Abbas;
>
> This has been very tough work.   It's very valuable because it is the
> fundamentals for triggers and global constraints.
>
> Because it passed long review process, the code is great.   Please let
> me have one question:  Are there any modification to reference
> document?


Yes there will be changes to the documentation, I will submit the patch for
that as soon as I finish the Query structure usage in DML planning work.



>   If there's some restrictions, I think we should include
> this.
>

Currently there is not restriction but there are a few things the user
needs to know when using DMLs on replicated tables with RETURNING. I will
try to cover them in the documentation changes.


>
> Regards;
> ----------
> Koichi Suzuki
>
>
> 2013/1/23 Abbas Butt <ga...@us...>:
> > Project "Postgres-XC".
> >
> > The branch, master has been updated
> >        via  f4a3652271d80627dcc28171eeccd7620ad397c7 (commit)
> >       from  e4279c68e3db231511025d4f2115fd459a3398ce (commit)
> >
> >
> > - Log -----------------------------------------------------------------
> >
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=f4a3652271d80627dcc28171eeccd7620ad397c7
> >
> > commit f4a3652271d80627dcc28171eeccd7620ad397c7
> > Author: Abbas <abb...@en...>
> > Date:   Wed Jan 23 13:53:14 2013 +0500
> >
> >     Add support for RETURNING clause in DMLs
> >
> >     The patch does the following major changes
> >
> >     1. Modifies the DML planning code to send the shippable part
> >        of the returning list to the datanodes in the remote query.
> >     2. Modifies the var references in returning list according to
> >        the target list that was sent to the datanodes since the
> >        tuples returned from the datanodes will contain vars in
> >        that order.
> >     3. Modifies remote query execution to make sure that a single
> >        response is accepted in case of DMLs on replicated tables
> >        with returning lists.
> >     4. Manages the fact that a DML can return tuples during remote
> >        query execution.
> >     5. Manages null tuples received from datanodes while counting
> >        modified tuples.
> >     6. Uses projection mechanism to show returned tuples
> >     7. Adds test cases.
> >
> >     Special thanks to Ashutosh for reviewing the patch.
> >
> > M       src/backend/executor/nodeModifyTable.c
> > M       src/backend/optimizer/plan/pgxcplan.c
> > M       src/backend/optimizer/plan/setrefs.c
> > M       src/backend/optimizer/util/pgxcship.c
> > M       src/backend/parser/parse_relation.c
> > M       src/backend/pgxc/pool/execRemote.c
> > M       src/backend/utils/adt/ruleutils.c
> > M       src/include/pgxc/execRemote.h
> > M       src/include/utils/builtins.h
> > M       src/test/regress/expected/plpgsql_1.out
> > M       src/test/regress/expected/rangefuncs_1.out
> > M       src/test/regress/expected/returning_1.out
> > M       src/test/regress/expected/triggers_1.out
> > M       src/test/regress/expected/with.out
> > M       src/test/regress/expected/xc_create_function.out
> > A       src/test/regress/expected/xc_returning.out
> > M       src/test/regress/parallel_schedule
> > M       src/test/regress/serial_schedule
> > M       src/test/regress/sql/returning.sql
> > M       src/test/regress/sql/with.sql
> > M       src/test/regress/sql/xc_create_function.sql
> > A       src/test/regress/sql/xc_returning.sql
> >
> > -----------------------------------------------------------------------
> >
> > Summary of changes:
> >  src/backend/executor/nodeModifyTable.c           |  127 ++-
> >  src/backend/optimizer/plan/pgxcplan.c            |  125 ++-
> >  src/backend/optimizer/plan/setrefs.c             |  141 +++-
> >  src/backend/optimizer/util/pgxcship.c            |    4 +
> >  src/backend/parser/parse_relation.c              |    7 -
> >  src/backend/pgxc/pool/execRemote.c               |  303 ++++-
> >  src/backend/utils/adt/ruleutils.c                |   33 +
> >  src/include/pgxc/execRemote.h                    |    5 +-
> >  src/include/utils/builtins.h                     |    1 +
> >  src/test/regress/expected/plpgsql_1.out          |   42 +-
> >  src/test/regress/expected/rangefuncs_1.out       |  178 +++-
> >  src/test/regress/expected/returning_1.out        |  269 +++--
> >  src/test/regress/expected/triggers_1.out         |   12 +-
> >  src/test/regress/expected/with.out               |  512 +++++++--
> >  src/test/regress/expected/xc_create_function.out |   23 +-
> >  src/test/regress/expected/xc_returning.out       | 1324
> ++++++++++++++++++++++
> >  src/test/regress/parallel_schedule               |    3 +-
> >  src/test/regress/serial_schedule                 |    1 +
> >  src/test/regress/sql/returning.sql               |   18 +-
> >  src/test/regress/sql/with.sql                    |   18 +-
> >  src/test/regress/sql/xc_create_function.sql      |   24 +-
> >  src/test/regress/sql/xc_returning.sql            | 1006 ++++++++++++++++
> >  22 files changed, 3834 insertions(+), 342 deletions(-)
> >  create mode 100644 src/test/regress/expected/xc_returning.out
> >  create mode 100644 src/test/regress/sql/xc_returning.sql
> >
> >
> > hooks/post-receive
> > --
> > Postgres-XC
> >
> >
> ------------------------------------------------------------------------------
> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > MVPs and experts. ON SALE this month only -- learn more at:
> > http://p.sf.net/sfu/learnnow-d2d
> > _______________________________________________
> > Postgres-xc-committers mailing list
> > Pos...@li...
> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
--
Abbas
Architect
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: 92-334-5100153

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of
the individual or entity to whom it is addressed. This message
contains information from EnterpriseDB Corporation that may be
privileged, confidential, or exempt from disclosure under applicable
law. If you are not the intended recipient or authorized to receive
this for the intended recipient, any use, dissemination, distribution,
retention, archiving, or copying of this communication is strictly
prohibited. If you have received this e-mail in error, please notify
the sender immediately by reply e-mail and delete this message.

Thanks a lot Abbas;

This has been very tough work.   It's very valuable because it is the
fundamentals for triggers and global constraints.

Because it passed long review process, the code is great.   Please let
me have one question:  Are there any modification to reference
document?   If there's some restrictions, I think we should include
this.

Regards;
----------
Koichi Suzuki


2013/1/23 Abbas Butt <ga...@us...>:
> Project "Postgres-XC".
>
> The branch, master has been updated
>        via  f4a3652271d80627dcc28171eeccd7620ad397c7 (commit)
>       from  e4279c68e3db231511025d4f2115fd459a3398ce (commit)
>
>
> - Log -----------------------------------------------------------------
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=f4a3652271d80627dcc28171eeccd7620ad397c7
>
> commit f4a3652271d80627dcc28171eeccd7620ad397c7
> Author: Abbas <abb...@en...>
> Date:   Wed Jan 23 13:53:14 2013 +0500
>
>     Add support for RETURNING clause in DMLs
>
>     The patch does the following major changes
>
>     1. Modifies the DML planning code to send the shippable part
>        of the returning list to the datanodes in the remote query.
>     2. Modifies the var references in returning list according to
>        the target list that was sent to the datanodes since the
>        tuples returned from the datanodes will contain vars in
>        that order.
>     3. Modifies remote query execution to make sure that a single
>        response is accepted in case of DMLs on replicated tables
>        with returning lists.
>     4. Manages the fact that a DML can return tuples during remote
>        query execution.
>     5. Manages null tuples received from datanodes while counting
>        modified tuples.
>     6. Uses projection mechanism to show returned tuples
>     7. Adds test cases.
>
>     Special thanks to Ashutosh for reviewing the patch.
>
> M       src/backend/executor/nodeModifyTable.c
> M       src/backend/optimizer/plan/pgxcplan.c
> M       src/backend/optimizer/plan/setrefs.c
> M       src/backend/optimizer/util/pgxcship.c
> M       src/backend/parser/parse_relation.c
> M       src/backend/pgxc/pool/execRemote.c
> M       src/backend/utils/adt/ruleutils.c
> M       src/include/pgxc/execRemote.h
> M       src/include/utils/builtins.h
> M       src/test/regress/expected/plpgsql_1.out
> M       src/test/regress/expected/rangefuncs_1.out
> M       src/test/regress/expected/returning_1.out
> M       src/test/regress/expected/triggers_1.out
> M       src/test/regress/expected/with.out
> M       src/test/regress/expected/xc_create_function.out
> A       src/test/regress/expected/xc_returning.out
> M       src/test/regress/parallel_schedule
> M       src/test/regress/serial_schedule
> M       src/test/regress/sql/returning.sql
> M       src/test/regress/sql/with.sql
> M       src/test/regress/sql/xc_create_function.sql
> A       src/test/regress/sql/xc_returning.sql
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  src/backend/executor/nodeModifyTable.c           |  127 ++-
>  src/backend/optimizer/plan/pgxcplan.c            |  125 ++-
>  src/backend/optimizer/plan/setrefs.c             |  141 +++-
>  src/backend/optimizer/util/pgxcship.c            |    4 +
>  src/backend/parser/parse_relation.c              |    7 -
>  src/backend/pgxc/pool/execRemote.c               |  303 ++++-
>  src/backend/utils/adt/ruleutils.c                |   33 +
>  src/include/pgxc/execRemote.h                    |    5 +-
>  src/include/utils/builtins.h                     |    1 +
>  src/test/regress/expected/plpgsql_1.out          |   42 +-
>  src/test/regress/expected/rangefuncs_1.out       |  178 +++-
>  src/test/regress/expected/returning_1.out        |  269 +++--
>  src/test/regress/expected/triggers_1.out         |   12 +-
>  src/test/regress/expected/with.out               |  512 +++++++--
>  src/test/regress/expected/xc_create_function.out |   23 +-
>  src/test/regress/expected/xc_returning.out       | 1324 ++++++++++++++++++++++
>  src/test/regress/parallel_schedule               |    3 +-
>  src/test/regress/serial_schedule                 |    1 +
>  src/test/regress/sql/returning.sql               |   18 +-
>  src/test/regress/sql/with.sql                    |   18 +-
>  src/test/regress/sql/xc_create_function.sql      |   24 +-
>  src/test/regress/sql/xc_returning.sql            | 1006 ++++++++++++++++
>  22 files changed, 3834 insertions(+), 342 deletions(-)
>  create mode 100644 src/test/regress/expected/xc_returning.out
>  create mode 100644 src/test/regress/sql/xc_returning.sql
>
>
> hooks/post-receive
> --
> Postgres-XC
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnnow-d2d
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers